Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE REFACTOR] - Commenting out flaky test #3634

Merged
merged 29 commits into from
Sep 7, 2017
Merged

[CODE REFACTOR] - Commenting out flaky test #3634

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
853090a
Code gen for ADLA
ro-joowan Jul 24, 2017
8a72cc4
Code gen for ADLS
ro-joowan Jul 24, 2017
d0429b1
Code gen for ADLS (part 2)
ro-joowan Jul 24, 2017
d97f093
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Jul 25, 2017
0bbe518
Code gen for ADL (part 3)
ro-joowan Jul 25, 2017
a01781f
Update Azure Batch to 5.1.0 (#3513)
matthchr Jul 27, 2017
3793362
Fixing publishing of symbols. Fixing issue# 3518 (#3519)
shahabhijeet Jul 27, 2017
9efe32f
Do hydra to swagger specs migration for azure-sdk-for-net (#3482)
Monicalyy Jul 27, 2017
caba128
Fix Batch changelog references (#3517)
matthchr Jul 27, 2017
528d017
Merge branch 'psSdkJson6' into psSdkJson6
ro-joowan Aug 2, 2017
2b8907f
Fixing changelog.md
ro-joowan Aug 3, 2017
c4593fb
Fixing up changelog.md
ro-joowan Aug 3, 2017
ddb1ea6
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Aug 7, 2017
ee186ba
[DataLake Analytics] Fixing changelog.md
ro-joowan Aug 7, 2017
75f6a49
[DataLake Store] Fixing changelog.md
ro-joowan Aug 7, 2017
deb131f
[DataLake Analytics] Fixing changelog.md
ro-joowan Aug 7, 2017
398f5b5
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Aug 12, 2017
7c8a514
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Aug 18, 2017
7338779
Revising custom Job Exists method
ro-joowan Aug 18, 2017
5eec416
Adding a TODO comment
ro-joowan Aug 18, 2017
b047658
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Aug 28, 2017
d45f70b
[CODE GEN] - Reverting readOnly for two fields
ro-joowan Aug 28, 2017
0487521
[CODE GEN] - Updating the version (3.1.0 to 3.1.1)
ro-joowan Aug 28, 2017
7c1e6f0
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Aug 30, 2017
61aeb65
[CODE REFACTOR] - Removing flaky test
ro-joowan Aug 30, 2017
f9b2727
[DOC] - Updating the changelog to describe 3.1.1-preview
ro-joowan Aug 30, 2017
69f1810
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
ro-joowan Sep 5, 2017
c9e918e
[CODE REFACTOR] - Skipping flaky test
ro-joowan Sep 6, 2017
2e516ca
Merge branch 'psSdkJson6' into psSdkJson6
shahabhijeet Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/SDKs/DataLake.Analytics/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
## Microsoft.Azure.Management.DataLake.Analytics release notes
### Changes in 3.1.1-preview

**Notes**

- In version 3.1.0-preview, we made the fields "statistics" and "debugData" of the USqlJobProperties object read-only. This caused some unforeseen conflicts, so we are reverting this.

### Changes in 3.1.0-preview

**Breaking changes**
Expand Down
2 changes: 1 addition & 1 deletion src/SDKs/DataLake.Store/DataLakeStore.Tests/DataTransferTests/DataLakeStoreClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public void DataLakeUploader_FreshUploadDownload()
/// <summary>
/// Tests the case of a fresh upload with multiple segments and multiple files.
/// </summary>
[Fact]
// [Fact]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ro-joowan rather than commenting the attribute, you should add the skip argument, this way that test is flagged as skipped in VS as well as Build logs
[Fact(Skip="Flaky test, need to fix it")]
Or
Rather simply delete the entire test, but commenting the test is kind of makes it confusing and it's hard to discover what is not being tested in the regression suite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet updated it so that it now skips. Thank you

public void DataLakeUploader_FreshFolderUploadDownload()
{
var frontEnd = new InMemoryFrontEnd();
Expand Down