Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET-specific changes: Move deprecated packages to legacy #36194

Merged
merged 17 commits into from
Sep 13, 2023

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented May 10, 2023

This PR also removes logic which attempts to resolve namespaces for a given package. The namespace resolution logic happens elsewhere (during package/metadata publishing) and is backfilled in instances where it isn't already present.

Example docs after running docindex: https://review.learn.microsoft.com/en-us/dotnet/api/overview/azure/?view=azure-dotnet-legacy&branch=djurek%2Ftest-legacy-migration

@github-actions
Copy link

Hi @danieljurek. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jul 14, 2023
@danieljurek
Copy link
Member Author

Keep this open.

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jul 14, 2023
@danieljurek danieljurek force-pushed the djurek/deprecated-packages-to-legacy branch from 1fe9972 to 8065bdd Compare August 24, 2023 05:48
@danieljurek danieljurek force-pushed the djurek/deprecated-packages-to-legacy branch from f960da1 to 25c2ad6 Compare September 6, 2023 15:35
@danieljurek danieljurek changed the title [WIP] Move deprecated packages to Legacy moniker .NET-specific changes: Move deprecated packages to legacy Sep 6, 2023
@danieljurek danieljurek self-assigned this Sep 6, 2023
@danieljurek danieljurek marked this pull request as ready for review September 6, 2023 16:47
@danieljurek danieljurek merged commit 1a1bdd6 into main Sep 13, 2023
@danieljurek danieljurek deleted the djurek/deprecated-packages-to-legacy branch September 13, 2023 21:15
m-nash added a commit that referenced this pull request Sep 14, 2023
* Revert "update api"

This reverts commit ae54d7d.

* Revert "remove serialization"

This reverts commit 748872b.

* Release v1.11.1 (#38602)

* [Event Hubs] September 2023 Release Prep (#38604)

The focus of these changes is to prepare the core Event Hubs library for
the September 2023 release.

* Sync eng/common directory with azure-sdk-tools repository (#38606)

* Don't allow setting Variant to Variant (#38592)

* Don't allow setting Variant to Variant

* pr fb

* Allow As<T> to return null for reference types (#38611)

* Allow As<T> to return null for reference types

* Improve cast exception message

* [Communication]Enable managed identity in ACScommunication resource sdk (#37566)

* Update autorest mark down to latest OpenApi spec

* initial code generation with new Swagger spec hash

* remove bugged format and generate code

* update spec link to remote link

* Adding test scenario for MI

* Update Export Api

* Update to most recent spec hash

* Update Sample Snippets

* Add Managed Identity tests session records assets

* Re-enforce resourceId format

* updated test recording

* updated recordings

* updated-recordings

* fix tests and Update test recordings

* Update changelog release history

* Provide backward compatibility to accomodate breaking change

* remove param from fallback overload

* Update customize folder with communication service resource data

* fix build issues

* fix build issues

* export api to support older resource data

* fix build issues

* Update release date of `1.2.0-beta.2`

---------

Co-authored-by: Joel Enikanorogbon <[email protected]>
Co-authored-by: Jorge Beauregard <[email protected]>
Co-authored-by: Mingzhe Huang <[email protected]>

* Increment package version after release of Microsoft.Azure.WebJobs.Extensions.SignalRService (#38618)

* Increment package version after release of Azure.ResourceManager.Communication (#38617)

* Increment package version after release of Azure.Messaging.EventHubs (#38627)

* [Event Hubs] September 2023 Release Prep (non-core) (#38605)

The focus of these changes is to prepare the Event Hubs processor and
function extensions libraries for the September 2023 release.

* Remove circular shared source references in Azure.Core tests files (#38607)

* Initial reshuffle

* Second reshuffle

* nits

* fix

* [SignalR extensions] Release v1.11.2 (#38623)

* Release v1.11.2

* Fix test issue

* STG 90 GA release prep (#38631)

* Fix release date for Confidential Ledger (#38629)

* Increment version for eventhub releases (#38632)

* Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventHubs

* Increment package version after release of Azure.Messaging.EventHubs.Processor

* [AppConfig] Update API Compat version (#38628)

The focus of these changes is to update the API Compat target after the 1.2.1 release.

* Prepare for release (#38612)

* Prepare for release

* change log

* Increment package version after release of Azure.Communication.JobRouter (#38641)

* Increment version for storage releases (#38642)

* revert some unexpected sample configuration changes (#38619)

* Update AutoRest C# version to 3.0.0-beta.20230912.3 (#38653)

* Increment package version after release of Azure.Security.ConfidentialLedger (#38644)

* update version to patch (#38646)

* Update dockerfile for net6.0 (#38645)

* NonDisposingStream: delegate remaining Stream APIs to inner stream (#38184)

* [App Config] Snapshot API Updates Based on Arch Board Feedback (#38650)

 [App Configuration] Updates in snapshot API

* Fix casing on some events (#38674)

* Legacy checkpoint support (#38546)

* Sync eng/common directory with azure-sdk-tools for PR 6895 (#38672)

* Add legacy moniker migration logic

* Add functionality from Java testing

---------

Co-authored-by: Daniel Jurek <[email protected]>

* .NET-specific changes: Move deprecated packages to legacy (#36194)

* First cut at migrating to legacy moniker

* Update-PackageMonikers.ps1

* Refinement

* Update docindex.yml for testing

* Rename

* ToC fixes

* Refactor namespace discovery

* Remove EnsureNamespaces

* Add "legacy" moniker

* Undo Service-Level-Readme-Automation.ps1 because it is generating incorrect package paths

* Better edge case handling, documentation

* Add fixes to service level overview generation

* Reset eng/common

* docindex changes

* Comment cleanup

* Fix ToC generation tests

* Test cleanup

* Remove unused <IncludeGeneratorSharedCode> MSBuild properties (#38648)

* Remove <IncludeGeneratorSharedCode> MSBuild properties

* revert personalizer

* Increment package version after release of Azure.Messaging.EventGrid (#38682)

* temp fix to release alpha package

* update api

* update code to not add new types

* update code to internalize types

* make model factory customer for now

* update api

* [Document Translation] Fix Document Translation README.md links (#38593)

* Fix Document Translation README.md links

* Remove extra whitespace and remove en-us from links

* Revert mocking link change

* Remove duplicate URL

---------

Co-authored-by: Rango Meadows <[email protected]>

* Prepare release for AppService (#38696)

* [WebPubSub] Increase isolated package version and fix a few issues (#38692)

* Increase isolated process package.

* Fix title

* Fixing scaler provider initialization pattern (#38673)

* src, test, and samples projects for DataMovement.Files.Shares (#38678)

* src, test, and samples projects for DataMovement.Files.Shares

* placeholder readme

* remove shared source

* more csproj

* blank changelog

---------

Co-authored-by: yzt <[email protected]>
Co-authored-by: Jesse Squire <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Anne Thompson <[email protected]>
Co-authored-by: Joel Eniqs <[email protected]>
Co-authored-by: Joel Enikanorogbon <[email protected]>
Co-authored-by: Jorge Beauregard <[email protected]>
Co-authored-by: Mingzhe Huang <[email protected]>
Co-authored-by: Sean McCullough <[email protected]>
Co-authored-by: Christopher Scott <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>
Co-authored-by: Reuben Bond <[email protected]>
Co-authored-by: ShivangiReja <[email protected]>
Co-authored-by: Alexey Rodionov <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Matthew Meadows (Rango the Dog) <[email protected]>
Co-authored-by: Rango Meadows <[email protected]>
Co-authored-by: Wei Hu <[email protected]>
Co-authored-by: JialinXin <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
yaotongms pushed a commit to yaotongms/azure-sdk-for-net that referenced this pull request Oct 12, 2023
* First cut at migrating to legacy moniker

* Update-PackageMonikers.ps1

* Refinement

* Update docindex.yml for testing

* Rename

* ToC fixes

* Refactor namespace discovery

* Remove EnsureNamespaces

* Add "legacy" moniker

* Undo Service-Level-Readme-Automation.ps1 because it is generating incorrect package paths

* Better edge case handling, documentation

* Add fixes to service level overview generation

* Reset eng/common

* docindex changes

* Comment cleanup

* Fix ToC generation tests

* Test cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants