[AppConfiguration] Snapshot API Updates #34583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pallavit
reviewed
Feb 28, 2023
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClient.cs
Outdated
Show resolved
Hide resolved
pallavit
reviewed
Feb 28, 2023
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClient.cs
Outdated
Show resolved
Hide resolved
m-redding
changed the title
sdk/appconfiguration/Azure.Data.AppConfiguration/src/autorest.md
Outdated
Show resolved
Hide resolved
m-redding
changed the title
m-redding
requested review from
nisha-bhatia,
AlexanderSher and
jsquire
as code owners
sdk/appconfiguration/Azure.Data.AppConfiguration/src/Models/SnapshotSettingFilter.cs
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/Azure.Data.AppConfiguration/src/Models/ConfigurationSettingsSnapshot.cs
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/Azure.Data.AppConfiguration/src/Models/ConfigurationSettingsSnapshot.cs
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClient.cs
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClient.cs
Outdated
Show resolved
Hide resolved
…is out of dogfoo in order to move forward
|
Will circle back to the LRO implementation once I can test again, I believe there are also updates that will be going into the swagger in order to be able to generate the Operation, which will also change the LRO implementation. |
ShivangiReja
reviewed
Apr 3, 2023
sdk/appconfiguration/Azure.Data.AppConfiguration/src/CreateSnapshotOperation.cs
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClient.cs
Show resolved
Hide resolved
|
Returned to the office today so I can access dogfood resources again. 😄 |
ShivangiReja
reviewed
Apr 3, 2023
sdk/appconfiguration/Azure.Data.AppConfiguration/tests/ConfigurationMockTests.cs
Show resolved
Hide resolved
sdk/appconfiguration/Azure.Data.AppConfiguration/tests/samples/Sample11_SettingsSnapshot.cs
Show resolved
Hide resolved
ShivangiReja
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
PR LGTM!!
I'll takeover the AppConfig work and update the implementation if needed. Thank you so much @m-redding for all the work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are based on discussions within the App Configuration SDK team across languages. The changes are based around the following:
CreateSnapshotandCreateSnapshotAsyncas LROsContributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.