Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analyze] Upgrade from Node 16 to Node 18 #33625

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jan 21, 2023

  • Latest autorest requires Node 17 or higher

Verification build: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2131987&view=results

- Latest autorest requires Node 17 or higher
@mikeharder mikeharder changed the title Upgrade from Node 16 to Node 18 in Analyze [Analyze] Upgrade from Node 16 to Node 18 Jan 21, 2023
@mikeharder mikeharder marked this pull request as ready for review January 21, 2023 02:05
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK moving forward to node 18 as long as the generation works as expected which seems like it does from CI jobs.

@weshaggard
Copy link
Member

We should link to issue Azure/azure-sdk-tools#5183 to outline why we needed to bump the version of node.

@AlexanderSher AlexanderSher merged commit d03e489 into Azure:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants