Remove ServiceToTest, CodeCheck run on service only #30754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is protected by Check Enforcer. |
sima-zhu
force-pushed
the
codecheck_improve
branch
from
45ad9ee
to
1fa7c5c
Compare
sima-zhu
changed the title
sima-zhu
force-pushed
the
codecheck_improve
branch
7 times, most recently
from
fb71b4a
to
c5848e4
Compare
sima-zhu
changed the title
sima-zhu
commented
Sep 12, 2022
sima-zhu
requested review from
hallipr,
benbp and
weshaggard
as code owners
weshaggard
reviewed
Sep 12, 2022
weshaggard
reviewed
Sep 12, 2022
weshaggard
reviewed
Sep 12, 2022
benbp
reviewed
Sep 13, 2022
benbp
reviewed
Sep 13, 2022
eng/scripts/splittestdependencies/generate-dependency-functions.ps1
Outdated
Show resolved
Hide resolved
benbp
approved these changes
Sep 13, 2022
sima-zhu
force-pushed
the
codecheck_improve
branch
from
f3deb89
to
62b5f22
Compare
sima-zhu
changed the title
sima-zhu
requested review from
jsquire,
maririos and
pallavit
as code owners
heaths
reviewed
Sep 16, 2022
eng/scripts/splittestdependencies/generate-dependency-functions.ps1
Outdated
Show resolved
Hide resolved
heaths
approved these changes
Sep 16, 2022
weshaggard
reviewed
Sep 19, 2022
weshaggard
approved these changes
Sep 19, 2022
sima-zhu
force-pushed
the
codecheck_improve
branch
2 times, most recently
from
ed1a612
to
a165c61
Compare
sima-zhu
force-pushed
the
codecheck_improve
branch
from
a165c61
to
7623ec5
Compare
|
/check-enforcer override |
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve Azure/azure-sdk-tools#3999
The PR is to speed up
Analyzejob for .NET core pipeline.Before it takes more than an hour to get it done.
After the changes
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1845393&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1845431&view=results
Our scope changes to run target service only in core pipeline for CodeCheck.ps1. Add code check in aggregate-report pipeline for awareness.
The following 2 scenarios can be covered from autogen pipeline. (For any possible flaws are supposed to address in autogen pipeine)
(Quote from Wes)
Note: Also make some changes to test splitting to make it robust.
Testing pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1856319&view=logs&j=d41e9505-d81b-5b3c-5b50-be71bc9b0ccb&t=7061cab9-8edd-561e-5078-022c316ef413