Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generation1-convenience-client flag #28187

Merged
merged 1 commit into from
Apr 13, 2022
Merged

add generation1-convenience-client flag #28187

merged 1 commit into from
Apr 13, 2022

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Apr 13, 2022 •
edited
Loading

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

We will set 'data-plane' as autorest.csharp codegen default target. and will add new tag 'generation1-convenience-client' tag for the HLC Client Library.

In order to upgrade to the new autorest.csharp which will use 'data-plane' as default target, we need to migrate current SDKs in azure-sdk-for-net step by step as following:

  1. Add new flag 'generation1-convenience-client' to all HLC SDKs
  2. Merge change in autorest.csharp Make data-plane default tag autorest.csharp#2146
  3. Upgrade autorest.csharp version and Remove old flag (data-plane) from the DPG SDKs

This pull request is #1

@azure-sdk
Copy link
Collaborator

API change check for Azure.Quantum.Jobs

API changes are not detected in this pull request for Azure.Quantum.Jobs

@azure-sdk
Copy link
Collaborator

API change check for Azure.AI.AnomalyDetector

API changes are not detected in this pull request for Azure.AI.AnomalyDetector

@azure-sdk
Copy link
Collaborator

API change check for Azure.AI.TextAnalytics

API changes are not detected in this pull request for Azure.AI.TextAnalytics

@azure-sdk
Copy link
Collaborator

API change check for Azure.DigitalTwins.Core

API changes are not detected in this pull request for Azure.DigitalTwins.Core

@azure-sdk
Copy link
Collaborator

API change check for Azure.AI.Language.Conversations

API changes are not detected in this pull request for Azure.AI.Language.Conversations

@azure-sdk
Copy link
Collaborator

API change check for Azure.Security.KeyVault.Administration

API changes are not detected in this pull request for Azure.Security.KeyVault.Administration

@azure-sdk
Copy link
Collaborator

API change check for Azure.AI.Language.QuestionAnswering

API changes are not detected in this pull request for Azure.AI.Language.QuestionAnswering

@azure-sdk
Copy link
Collaborator

API change check for Azure.Monitor.OpenTelemetry.Exporter

API changes are not detected in this pull request for Azure.Monitor.OpenTelemetry.Exporter

@azure-sdk
Copy link
Collaborator

API change check for Azure.Monitor.Query

API changes are not detected in this pull request for Azure.Monitor.Query

@azure-sdk
Copy link
Collaborator

API change check for Azure.AI.FormRecognizer

API changes are not detected in this pull request for Azure.AI.FormRecognizer

@azure-sdk
Copy link
Collaborator

API change check for Azure.Data.Tables

API changes are not detected in this pull request for Azure.Data.Tables

@azure-sdk
Copy link
Collaborator

API change check for Azure.Containers.ContainerRegistry

API changes are not detected in this pull request for Azure.Containers.ContainerRegistry

@azure-sdk
Copy link
Collaborator

API change check for Azure.Search.Documents

API changes are not detected in this pull request for Azure.Search.Documents

@azure-sdk
Copy link
Collaborator

API change check for Azure.Security.Attestation

API changes are not detected in this pull request for Azure.Security.Attestation

@azure-sdk
Copy link
Collaborator

API change check for Azure.MixedReality.Authentication

API changes are not detected in this pull request for Azure.MixedReality.Authentication

@azure-sdk
Copy link
Collaborator

API change check for Azure.Storage.Blobs

API changes are not detected in this pull request for Azure.Storage.Blobs

@azure-sdk
Copy link
Collaborator

API change check for Azure.Storage.Blobs.Batch

API changes are not detected in this pull request for Azure.Storage.Blobs.Batch

@azure-sdk
Copy link
Collaborator

API change check for Azure.Storage.Files.Shares

API changes are not detected in this pull request for Azure.Storage.Files.Shares

@azure-sdk
Copy link
Collaborator

API change check for Azure.Storage.Files.DataLake

API changes are not detected in this pull request for Azure.Storage.Files.DataLake

@azure-sdk
Copy link
Collaborator

API change check for Azure.Storage.Queues

API changes are not detected in this pull request for Azure.Storage.Queues

@reyang reyang removed their request for review April 13, 2022 05:25
lirenhe
lirenhe reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some description on why adding 'generation1-convenience-client'?
I saw a couple of people are added for reviewer and they may lack the context of this change.

@chunyu3
Copy link
Member Author

chunyu3 commented Apr 13, 2022

We will set 'data-plane' as autorest.csharp codegen default tag. and will add new tag 'generation1-convenience-client' tag for the HLC Client Library.
This pull request is to add the new flag for all the .NET HLC Client Library package.

After the Pull request is merged, we will upgrade the autorest.csharp version which will add 'data-plane' as default tag. That is, if no flag(azure-arm or generation1-convenience-client) is set, the autorest.csharp will generate DPG library.

@chunyu3 chunyu3 requested a review from lirenhe April 13, 2022 05:42
@chunyu3
Copy link
Member Author

chunyu3 commented Apr 13, 2022

The check 'net-synapse -ci' failed because the 'Microsoft.Azure.Synapse' package has invalid CHANGELOG.md file. And the issue is not caused by the pull request.

@chunyu3
Copy link
Member Author

chunyu3 commented Apr 13, 2022

/check-enforcer override

@chunyu3 chunyu3 merged commit b30fa6d into Azure:main Apr 13, 2022
@heaths
Copy link
Member

heaths commented Apr 13, 2022

@chunyu3 can you describe what this new setting does? Ideally, it would make a nice PR description as opposed to the default PR template meant more for external contributors to read and replace.

@lirenhe
Copy link
Member

lirenhe commented Apr 21, 2022

@heaths, i see the explaination of this PR in the description, do you still have question related to the new settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe approved these changes

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@wonner wonner Awaiting requested review from wonner

@idear1203 idear1203 Awaiting requested review from idear1203

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft is a code owner

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@amnguye amnguye Awaiting requested review from amnguye amnguye is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

@arv100kri arv100kri Awaiting requested review from arv100kri

@bleroy bleroy Awaiting requested review from bleroy

@Mohit-Chakraborty Mohit-Chakraborty Awaiting requested review from Mohit-Chakraborty

@cijothomas cijothomas Awaiting requested review from cijothomas

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@TimothyMothra TimothyMothra Awaiting requested review from TimothyMothra TimothyMothra is a code owner

@vishweshbankwar vishweshbankwar Awaiting requested review from vishweshbankwar

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia nisha-bhatia is a code owner

@heaths heaths Awaiting requested review from heaths

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@drwill-ms drwill-ms Awaiting requested review from drwill-ms

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra

@azabbasi azabbasi Awaiting requested review from azabbasi

@brycewang-microsoft brycewang-microsoft Awaiting requested review from brycewang-microsoft

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

@ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

@jfggdl jfggdl Awaiting requested review from jfggdl

@yeskarthik yeskarthik Awaiting requested review from yeskarthik yeskarthik is a code owner

@rasidhan rasidhan Awaiting requested review from rasidhan rasidhan is a code owner

@johngallardo johngallardo Awaiting requested review from johngallardo johngallardo is a code owner

@Aashish93-stack-zz Aashish93-stack-zz Awaiting requested review from Aashish93-stack-zz

@sjiherzig sjiherzig Awaiting requested review from sjiherzig sjiherzig is a code owner

@maririos maririos Awaiting requested review from maririos

@kinelski kinelski Awaiting requested review from kinelski kinelski is a code owner

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

Assignees
No one assigned
Labels
Cognitive - Form Recognizer Cognitive - Metrics Advisor Cognitive - Text Analytics Communication Digital Twins Event Grid IoT KeyVault Schema Registry Search Storage Storage Service (Queues, Blobs, Files) Tables TimeseriesInsights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chunyu3 @azure-sdk @heaths @lirenhe