Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regen with response error #27961

Merged
merged 17 commits into from
Apr 4, 2022
Merged

Regen with response error #27961

merged 17 commits into from
Apr 4, 2022

Conversation

m-nash
Copy link
Member

@m-nash m-nash commented Apr 4, 2022

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

m-nash added 15 commits March 30, 2022 12:29
@m-nash
update azure.core to have reference type on ResponseError
f536b5e
@m-nash
address feedback on comments
8e76fc0
@m-nash
regen with new autorest
870b314
@m-nash
update api
30d4dd9
@m-nash
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
abf89b3 
…o mnash-regenWithResponseError
@m-nash
add extra files to set up for shared source
3237bfc
@m-nash
remove from proj the two files core doesn't use
768fa2a
@m-nash
Merge branch 'mnash-corePropertyRef' of https://github.com/Azure/azur…
e337dd8 
…e-sdk-for-net into mnash-regenWithResponseError
@m-nash
merge from main
3e0982d
@m-nash
add default constructor for general case
54764ee
@m-nash
Merge branch 'mnash-corePropertyRef' of https://github.com/Azure/azur…
0ef1bcc 
…e-sdk-for-net into mnash-regenWithResponseError
@m-nash
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
92f4969 
…o mnash-regenWithResponseError
@m-nash
regen against latest atuorest
ecd1c11
@m-nash
merge from main
f1d759e
@m-nash
update api after merge
44f9373
@ghost ghost added Communication Event Hubs Storage Storage Service (Queues, Blobs, Files) labels Apr 4, 2022
@m-nash m-nash mentioned this pull request Apr 4, 2022
Closed
@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.EdgeOrder

API changes have been detected in Azure.ResourceManager.EdgeOrder. You can review API changes here

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.StoragePool

API changes are not detected in this pull request for Azure.ResourceManager.StoragePool

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.ConnectedVMwarevSphere

API changes have been detected in Azure.ResourceManager.ConnectedVMwarevSphere. You can review API changes here

API changes

-     public class ErrorDetail {
-         public string Code { get; }
-         public IReadOnlyList<ErrorDetail> Details { get; }
-         public string Message { get; }
-         public string Target { get; }
-     }
-         public IReadOnlyList<ErrorDetail> ErrorDetails { get; }
+         public IReadOnlyList<ResponseError> ErrorDetails { get; }

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.EventHubs

API changes are not detected in this pull request for Azure.ResourceManager.EventHubs

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager

API changes have been detected in Azure.ResourceManager. You can review API changes here

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Resources

API changes have been detected in Azure.ResourceManager.Resources. You can review API changes here

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.ExtendedLocation

API changes are not detected in this pull request for Azure.ResourceManager.ExtendedLocation

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.DnsResolver

API changes are not detected in this pull request for Azure.ResourceManager.DnsResolver

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Dashboard

API changes are not detected in this pull request for Azure.ResourceManager.Dashboard

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.DeviceUpdate

API changes are not detected in this pull request for Azure.ResourceManager.DeviceUpdate

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Monitor

API changes are not detected in this pull request for Azure.ResourceManager.Monitor

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.WebPubSub

API changes are not detected in this pull request for Azure.ResourceManager.WebPubSub

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Hci

API changes are not detected in this pull request for Azure.ResourceManager.Hci

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.HybridConnectivity

API changes are not detected in this pull request for Azure.ResourceManager.HybridConnectivity

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.AppService

API changes have been detected in Azure.ResourceManager.AppService. You can review API changes here

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Communication

API changes are not detected in this pull request for Azure.ResourceManager.Communication

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Cdn

API changes are not detected in this pull request for Azure.ResourceManager.Cdn

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Network

API changes are not detected in this pull request for Azure.ResourceManager.Network

@azure-sdk
Copy link
Collaborator

API change check for Azure.ResourceManager.Storage

API changes are not detected in this pull request for Azure.ResourceManager.Storage

@m-nash m-nash mentioned this pull request Apr 4, 2022
Merged
@m-nash m-nash marked this pull request as ready for review April 4, 2022 18:52
@azure-sdk
Copy link
Collaborator

API change check for Azure.Containers.ContainerRegistry

API changes are not detected in this pull request for Azure.Containers.ContainerRegistry

@m-nash m-nash enabled auto-merge (squash) April 4, 2022 19:35
@m-nash m-nash merged commit e2aec8b into main Apr 4, 2022
@m-nash m-nash deleted the mnash-responseErro branch April 4, 2022 20:24
@mikeharder mikeharder mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohit-Chakraborty Mohit-Chakraborty Mohit-Chakraborty approved these changes

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@archerzz archerzz Awaiting requested review from archerzz archerzz is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@Yao725 Yao725 Awaiting requested review from Yao725

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft is a code owner

Assignees
No one assigned
Labels
Communication Event Hubs Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-nash @azure-sdk @Mohit-Chakraborty