Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps: Search SDK onboarding #25762

Closed

Conversation

ambientlight
Copy link
Member

@ambientlight ambientlight commented Dec 7, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

APIView review:
rev 3 - Azure.Maps.Search (1.0.0.0)

ambientlight and others added 24 commits November 20, 2021 19:57
@ambientlight ambientlight changed the title Maps: Search Maps: Search SDK onboarding Dec 7, 2021
@check-enforcer
Copy link

check-enforcer bot commented Dec 7, 2021

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

Taras Vozniuk added 4 commits December 8, 2021 17:27
…d5b915b41147beb1c6c3268f8ae349

1. Polygon::ProviderID -> Polygon::ProviderId,
2. SearchAddressResultItem::Info -> SearchAddressResultItem::DataSourceInfo
3. Classification -> PointOfInterestClassification
4. OperatingHoursTimeRange StartTime/EndTime as DateTimeOffset
5. JsonFormat as internal type
6. OperatingHoursTIme as internal type
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Feb 11, 2022
@ghost
Copy link

ghost commented Feb 11, 2022

Hi @ambientlight. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Feb 18, 2022
@ghost
Copy link

ghost commented Feb 18, 2022

Hi @ambientlight. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant