Constrain NetworkTimeout on IMDS calls from DefaultAzureCredential #24328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
christothes
reviewed
Sep 30, 2021
christothes
reviewed
Sep 30, 2021
pakrym
reviewed
Oct 1, 2021
sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Oct 1, 2021
sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Oct 1, 2021
schaabs
requested review from
chidozieononiwu,
danieljurek and
weshaggard
as code owners
weshaggard
reviewed
Oct 1, 2021
christothes
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to our IMDS discovery model have regressed the perfomance of the
DefaultAzureCredentialon certain platforms where the IMDS endpoint is not available. This change introduces an internal setting to limit theNetworkTimeouton our initial IMDS calls.The limit is 1 second the same as the original limit which was put on establishing an socket connection in the previous discovery model. If a response is received from the IMDS endpoint the limit is removed.