-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] More managed disk coverage #23140
Merged
kasobol-msft
merged 11 commits into
Azure:main
from
kasobol-msft:more-managed-disk-coverage
Aug 5, 2021
Merged
[Storage] More managed disk coverage #23140
kasobol-msft
merged 11 commits into
Azure:main
from
kasobol-msft:more-managed-disk-coverage
Aug 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasobol-msft
requested review from
amishra-dev,
amnguye,
seanmcc-msft and
tg-msft
as code owners
August 5, 2021 21:05
amnguye
approved these changes
Aug 5, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
May 4, 2023
Dev cost management microsoft.cost management 2023 04 01 preview (Azure#23334) * Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * Adding Budgets API translated from 2022-10-01 stable version of Micro… (Azure#22866) * Adding Budgets API translated from 2022-10-01 stable version of Microsoft.Consumption/budgets * Updating api-version in examples to 2023-04-01-preview * Adding costmanagement.budgets.json to readme * Addressing Swagger LintDiff errors * Updating budget name pattern * Adding suppression for R4011 * Adding budget name pattern regex for only alphanumeric, underscore, or hyphen characters * fixing readme.go.md for budgets * removing "object" type from notifications dictionary keys * removing tags * removing mismatching enum values * updating notifications key type * Revert "updating notifications key type" This reverts commit eeb504b9016fb2214811e279da4ee318c37f6652. * Revert "removing mismatching enum values" This reverts commit cba0132bac27f831c90ef8cfca836c8853680000. * updates to enum name * Removing incorrect/outdated description info * fixing BudgetsList example * Updating example Ids to use Microsoft.CostManagement RP * updating min & max length of budget name per conversations with PMs * Adding suppressions for DeleteOperationResponses, TopLevelResourcesListBySubscription, and NoDuplicatePathsForScopeParameter * fixing indentation in readme * fixing formatting of suppressions in readme * Adding paging back in, specifying as null for future use * Adding support for RU Alerts in new Budgets API version (Azure#23140) * Updating budgets swagger definition to include modifications from RU Alert category * Adding new examples for all scenarios of RU Alerts, added new examples for all scopes for Cost Budgets * Spelling & lintdiff fixes * prettier-fix * Added more descriptions, and some light markdown to larger descripitons * Addressing comments * prettier-fix * Updating description for amount property * addressing Shravan's offline comments * spell check * removing aws scopes from scope description * Addressing comments from internal review, removed legacy tags for EA * Alexprosak microsoft.cost management 2023 04 01 preview (Azure#23362) * Updating readme default tag * specifiying the word "update" in 200 response for budget createorupdate * updating tags to package-preview-2023-04-01 * readme test * Revert "readme test" This reverts commit 566e2e6dbcecc8ed3d0c31770788abcaed4840f8. * Revert "updating tags to package-preview-2023-04-01" This reverts commit f9cf3fe3474820afaad0163800aa2548343fae62. * Updating readme with previous apis not included and updated to current version * Revert "Updating readme with previous apis not included and updated to current version" This reverts commit bb879469fea9bf11852334822369310ee6a64534. * Alexprosak cost management microsoft.cost management 2023 04 01 preview (Azure#23770) * changing azure-sdk-for-net to azure-sdk-for-net-track2 per ask from comment on main branch PR * Adding in descriptions + examples for RU Alerts support at the customer scope * fixing json formatting * fixing example references * Updating costmanagementproxyresource to reference ARM common proxy resource. Minor formatting change on scope parameter * Updating common-types with updates to common-types from 2022-10-01 version * prettier-fix * Alprosms cost management microsoft.cost management 2023 04 01 preview (Azure#23795) * updating costdetailreport swaggers from recent changes to 2022-10-01 version * suppressing invalid LintDiff errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.