-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update containerinstance client to the 2021-03-01 api #22701
Conversation
Hi, could you please provide the approved swagger PR? |
@JonathanCrd |
...rinstance/Microsoft.Azure.Management.ContainerInstance/src/Generated/ContainersOperations.cs
Show resolved
Hide resolved
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run net - mgmt - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving changes, fix the CI errors to merge.
/check-enforcer reset |
/check-enforcer evaluate |
/azp run net - mgmt - ci |
Commenter does not have sufficient privileges for PR 22701 in repo Azure/azure-sdk-for-net |
/azp run net - mgmt - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@JonathanCrd Thanks for starting the pipeline, looks like it failed again: D:\a\1.nuget\packages\microsoft.internal.netsdkbuild.mgmt.tools\0.12.0-dev.20210610.1\targets\common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [D:\a\1\s\mgmt.proj] |
@JonathanCrd I'm not seeing anything helpful in CI pipeline output to explain the failures. How can we move forward and unblock the CI issues? |
...rinstance/Microsoft.Azure.Management.ContainerInstance/src/Generated/ContainersOperations.cs
Outdated
Show resolved
Hide resolved
...instance/Microsoft.Azure.Management.ContainerInstance/src/Generated/IContainersOperations.cs
Show resolved
Hide resolved
...Microsoft.Azure.Management.ContainerInstance/src/Generated/ContainersOperationsExtensions.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One requested change - the failures in net-mgmt-ci look to be places where you need to re-record the tests.
...ance/Microsoft.Azure.Management.ContainerInstance/src/Customizations/ContainersOperations.cs
Outdated
Show resolved
Hide resolved
...ance/Microsoft.Azure.Management.ContainerInstance/src/Customizations/ContainersOperations.cs
Outdated
Show resolved
Hide resolved
@joseph-porter The mgmt tests are now passing. Need to figure out why the data plane tests, which this PR shouldn't impaxct are affected. @weshaggard any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to propagate the method signature change to the extension class as well. Otherwise, thsi is ready to go.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
This generation includes a new API version 2021-03-01: Azure/azure-rest-api-specs#12825
As well as an update to a previous API version: Azure/azure-rest-api-specs#12129