Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containerinstance client to the 2021-03-01 api #22701

Merged
merged 12 commits into from
Aug 10, 2021

Conversation

joseph-porter
Copy link
Contributor

@joseph-porter joseph-porter commented Jul 16, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

This generation includes a new API version 2021-03-01: Azure/azure-rest-api-specs#12825
As well as an update to a previous API version: Azure/azure-rest-api-specs#12129

@JonathanCrd
Copy link
Member

Hi, could you please provide the approved swagger PR?

@joseph-porter
Copy link
Contributor Author

@JonathanCrd
This generation includes a new API version 2021-03-01: Azure/azure-rest-api-specs#12825
As well as an update to a previous API version: Azure/azure-rest-api-specs#12129

@allenjzhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@allenjzhang
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@JonathanCrd JonathanCrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes, fix the CI errors to merge.

@joseph-porter
Copy link
Contributor Author

/check-enforcer reset

@joseph-porter
Copy link
Contributor Author

/check-enforcer evaluate

@joseph-porter
Copy link
Contributor Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 22701 in repo Azure/azure-sdk-for-net

@JonathanCrd
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joseph-porter
Copy link
Contributor Author

@JonathanCrd Thanks for starting the pipeline, looks like it failed again:

D:\a\1.nuget\packages\microsoft.internal.netsdkbuild.mgmt.tools\0.12.0-dev.20210610.1\targets\common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [D:\a\1\s\mgmt.proj]

@joseph-porter
Copy link
Contributor Author

@JonathanCrd I'm not seeing anything helpful in CI pipeline output to explain the failures. How can we move forward and unblock the CI issues?

@allenjzhang allenjzhang assigned yungezz and unassigned JonathanCrd Aug 2, 2021
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change - the failures in net-mgmt-ci look to be places where you need to re-record the tests.

@joseph-porter
Copy link
Contributor Author

@markcowl @yungezz Any updates here?

We're trying to update the SDK to address a customer issue, so hoping to make quick progress here.

@markcowl
Copy link
Member

@joseph-porter The mgmt tests are now passing. Need to figure out why the data plane tests, which this PR shouldn't impaxct are affected. @weshaggard any ideas?

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to propagate the method signature change to the extension class as well. Otherwise, thsi is ready to go.

@markcowl markcowl merged commit 3975c87 into Azure:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants