Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] PageBlobClient request condition validation #21976

Merged
merged 10 commits into from
Jun 22, 2021
Merged

[Storage] PageBlobClient request condition validation #21976

merged 10 commits into from
Jun 22, 2021

Conversation

seanmcc-msft
Copy link
Member

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 18, 2021
@seanmcc-msft seanmcc-msft mentioned this pull request Jun 18, 2021
Closed
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@seanmcc-msft
Copy link
Member Author

/azp run net - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@seanmcc-msft seanmcc-msft merged commit 240860b into Azure:main Jun 22, 2021
@seanmcc-msft seanmcc-msft deleted the feature/storage/pageBlobRequestValidation branch June 22, 2021 18:24
@stliu stliu mentioned this pull request Aug 16, 2022
Closed
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Jan 6, 2023
CodeGen from PR 21976 in Azure/azure-rest-api-specs
0b6fd75 
Add new tier and sku - Standard_Basic for Application Gateway (Azure#21976)

* Add new tier and sku for standard_basic

* spaces
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Jan 6, 2023
CodeGen from PR 21976 in Azure/azure-rest-api-specs
a1a2184 
Add new tier and sku - Standard_Basic for Application Gateway (Azure#21976)

* Add new tier and sku for standard_basic

* spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasobol-msft kasobol-msft kasobol-msft approved these changes

@amnguye amnguye amnguye approved these changes

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanmcc-msft @amnguye @kasobol-msft