-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure.Core.Amqp] Lazy Allocation for All Sections #21791
Conversation
LGTM. In terms of logistics, we still are planning on GAing the body types in next week or so. I'd rather wait to ship HasSection until we've implemented it in Event Hubs to prove that the API is correct. |
No objections from me. To be clear, are we comfortable with shipping the body types from a commit or are you asking me to hold off on merging until after that point? |
I'd prefer to ship from tip of master. I'm not opposed to including this in the GA, but I would prefer to wait until we've done a validation of the API through Event Hubs. |
I'll leave this open, then, until we ship. |
/check-enforcer evaluate |
The focus of these changes is to enable lazy allocation for all sections of the `AmqpAnnotatedMessage` type, to match the AMQP spec definition. (see: http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format) In order to allow downstream consumers to test if a section is populated without triggering allocation for the property, the `HasSection` member has been added.
bf3bb29
to
3de1b87
Compare
Summary
The focus of these changes is to enable lazy allocation for all sections of the
AmqpAnnotatedMessage
type, to align with them being defined as optional by the AMQP specification. In order to allow downstream consumers to test if a section is populated without triggering allocation for the property, theHasSection
member has been added.References and Resources