-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Compute folder from Master, and updated tests for 2021-03 #21209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significant revisions to the API surface to reflect API review comments. Co-authored-by: Jesse Squire <[email protected]>
) * Re-enabling Unauthorized Number SMS Test * Update recordings Co-authored-by: Minnie Liu <[email protected]>
* Add DLQ sample * Fix broken links * PR FB
* Update to rest spec version d95c18e2 Introduce SearchIndexerKnowledgeStore * Add tests for KnowledgeStore in skillsets * Update sample in markdown * Fix code that sanitizes storage account key from session records
* refactor batch
DevOps helper scripts were updated in azure-sdk repo so syncing those changes into the tools repo so they can be used prepare-release script. Co-authored-by: Wes Haggard <[email protected]>
* Renamed ModelFactory methods to align with Azure naming guidelines.
The focus of these changes is to fix a bug in which load balancing incorrectly identifies a need to attempt to steal a partition (even from itself) and then fails to find an eligible candidate partition after running unnecessary logic. This manifests only as a log message for host applications, as partitions were never actually stolen.
* add multivariate test sample * add multivariate in README * add md file for multivariate detect * fix * Add broken links to ingore-links.txt * add snippet * align snippet name in md and cs file; skip line after main method * update after snippet generation and code generation * remove trailing whitespace; correct links * remove the added ignore links for anomaly detector Co-authored-by: Shivangi Reja <[email protected]>
The focus of these changes is to fix the "Source code" link in the README to reference the correct location.
When there are no Flags set, we should pass null to the service
…licitly (#20790) Update tests to validate change in behavior
…20781) * Adding Subscription Configurations to tests.yml * Fix formatting * Updating tset-resources.json * Fix formatting * Fix indent * Add extra line * Revert test-resources.json * Change back test-resources.json * Change back test-resources.json * Cleanup test-resources * Adressed review comments * Fix pipeline Co-authored-by: Minnie Liu <[email protected]>
* Respect webproxy from config * PR FB * Rename to ClientRetryOptions for consistency with EH * Fix test * Fix test * PR FB * Export API * Update dependency * Update reference * Use ToString for URI * Revert ToString * Fix JSON deserialization issue * Remove unused code
* Allow propogation of SetDevVersion. * Allow use of SetDevVersion locally and across stages. Co-authored-by: Mitch Denny <[email protected]>
* Added ContentType Extensible Enum * Update sdk/core/Azure.Core.Experimental/src/ContentType.cs Co-authored-by: Pavel Krymets <[email protected]> * Updated API file Co-authored-by: Pavel Krymets <[email protected]>
* Make RELEASE_TITLE_REGEX more specific * Update eng/common/scripts/ChangeLog-Operations.ps1 Co-authored-by: Wes Haggard <[email protected]> * Update release REGEX * tighten up changelog verification * Ensure releaseDate is in the appriopriate format. * Update error messages. * Retrun false after error Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Kalpesh Chavan <[email protected]>
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventHubs
* rename analyze to remove batch * add changelog
* Resource Identity fixes for SQL Server * Modified assemblyinfo and csproj
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Blobs
Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Queues
* Generated based on new api-version 2020-12-01 * Addressed Code review comments. * 2020-12 version is reverted/ * Generated with 2020-12 version * Revert "Generated with 2020-12 version" This reverts commit e6178a7cb54aec24d7b9547cd6752b4d4978d41d. * .Net SDK generated for version "2020-12-01" * Latest changes for apiversion:2020-12
* Sparse checkout docs repository in release step * Detect default branch for custom sparse checkout repository * Use sparse checkout paths parameter in docs metadata release Co-authored-by: Ben Broderick Phillips <[email protected]>
* SB extension API updates * PR FB
* updating links and changelog * updating links
* Fix ShareLink sample to be able to build again Relates to #21074 * Build Key Vault samples in CI
…CS NetworkTraversal SDK (#21094) * Adding the Azure.Communication.NetworkTraversal SDK * Adding the Azure.Communication.NetworkTraversal SDK - update
ghost
added
the
Compute
label
May 19, 2021
Sandido
requested review from
allenjzhang,
bquantump,
KrzysztofCwalina,
m-nash,
markcowl,
nisha-bhatia,
tg-msft and
YalinLi0312
as code owners
May 19, 2021 22:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.