Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to enable NuGet.org README.md display #21157

Merged
merged 17 commits into from
Jun 21, 2021
Merged

Add a flag to enable NuGet.org README.md display #21157

merged 17 commits into from
Jun 21, 2021

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented May 18, 2021

Contributes to #21160

@pakrym pakrym requested a review from weshaggard May 18, 2021 19:09
@ghost ghost added the EngSys This issue is impacting the engineering system. label May 18, 2021
@pakrym
Copy link
Contributor Author

pakrym commented May 18, 2021

Requires new SDK will wait a bit.

global.json Outdated Show resolved Hide resolved
@pakrym pakrym closed this May 19, 2021
@pakrym pakrym reopened this May 26, 2021
@pakrym
Copy link
Contributor Author

pakrym commented May 26, 2021

Couple problems (https://www.nuget.org/packages/Azure.Template/1.0.3-beta.914605#):

  1. HTML-style comments are displayed.
  2. Common bar display.
    image
  3. Link labels are not removed
    image

@pakrym
Copy link
Contributor Author

pakrym commented May 26, 2021

I think we can pre-process the markdown ourselves. But I'll file an issue on Nuget first and see if they are open to making changes in their generation.

@pakrym
Copy link
Contributor Author

pakrym commented Jun 8, 2021

Filed NuGet/NuGetGallery#8627 but also added a pre-process script.

@check-enforcer
Copy link

check-enforcer bot commented Jun 8, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@pakrym pakrym marked this pull request as ready for review June 8, 2021 23:19
global.json Outdated Show resolved Hide resolved
@pakrym
Copy link
Contributor Author

pakrym commented Jun 10, 2021

Also filed NuGet/NuGetGallery#8632

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable once folks are OK with moving to the new toolset.

@pakrym
Copy link
Contributor Author

pakrym commented Jun 21, 2021

/azp run net - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pakrym
Copy link
Contributor Author

pakrym commented Jun 21, 2021

/check-enforcer override

@pakrym pakrym merged commit 09cc00a into main Jun 21, 2021
@pakrym pakrym deleted the feature/readmemd branch June 21, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants