-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recovery services site recovery - sdk for net - for new API version 2021-02-10 #20004
Recovery services site recovery - sdk for net - for new API version 2021-02-10 #20004
Conversation
@nilgupta6 can we open this as a draft PR if its not intended to be reviewed / merged? |
@m-nash : We want it to be reviewed but we will merge it once our swagger PR is merged. |
@m-nash FYI: |
a6f138d
to
19c9d96
Compare
19c9d96
to
ce3ccd8
Compare
@m-nash / @allenjzhang This is time critical for us. We have to push powershell PR by friday. |
19c9165
to
a8e2642
Compare
@allenjzhang |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:Swagger PR: New API version (2021-02-10) for recovery services site recovery azure-rest-api-specs#13525
General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.