Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery services site recovery - sdk for net - for new API version 2021-02-10 #20004

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

nilgupta6
Copy link
Contributor

@nilgupta6 nilgupta6 commented Mar 31, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Compute label Mar 31, 2021
@nilgupta6 nilgupta6 changed the title [DO NOT MERGE]recovery services site recovery sdk for net for API version 2021-02-10 [DO NOT MERGE] Recovery services site recovery - sdk for net - for new API version 2021-02-10 Mar 31, 2021
@m-nash
Copy link
Member

m-nash commented Apr 1, 2021

@nilgupta6 can we open this as a draft PR if its not intended to be reviewed / merged?

@nilgupta6 nilgupta6 closed this Apr 6, 2021
@nilgupta6 nilgupta6 reopened this Apr 6, 2021
@nilgupta6
Copy link
Contributor Author

@nilgupta6 can we open this as a draft PR if its not intended to be reviewed / merged?

@m-nash : We want it to be reviewed but we will merge it once our swagger PR is merged.
Can you please review it.

@nilgupta6
Copy link
Contributor Author

nilgupta6 commented Apr 15, 2021

@m-nash
Can you please start reviewing it.
our swagger is approved (Azure/azure-rest-api-specs#13525). We are waiting for service release to merge swagger PR.
We will run generate.ps1 after swagger PR merge is done. Please start review meanwhile.

FYI:
@ayfathim / @vidyadharijami / @Arpitaji

@nilgupta6
Copy link
Contributor Author

@m-nash / @allenjzhang
Can you please review / approve this.

This is time critical for us. We have to push powershell PR by friday.

@nilgupta6 nilgupta6 changed the title [DO NOT MERGE] Recovery services site recovery - sdk for net - for new API version 2021-02-10 Recovery services site recovery - sdk for net - for new API version 2021-02-10 Apr 21, 2021
@nilgupta6 nilgupta6 force-pushed the newApiVersion/asr2021-02-10 branch from 19c9165 to a8e2642 Compare April 21, 2021 20:28
@nilgupta6
Copy link
Contributor Author

nilgupta6 commented Apr 21, 2021

See verification discrepancies. https://dev.azure.com/azure-sdk/public/_build/results?buildId=854383&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=50b9345f-2a7f-5980-cb0f-1a8f9fb09dd0&l=190

@allenjzhang
I have updated files. This should resolve verification discrepancies.
please review and merge if everything is OK

@allenjzhang allenjzhang merged commit 9ff47f0 into Azure:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants