Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Analytics] Improve healthcare samples #19248

Merged
merged 10 commits into from
Mar 5, 2021
Merged

Conversation

suhas92
Copy link
Member

@suhas92 suhas92 commented Mar 5, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@suhas92 suhas92 requested a review from maririos March 5, 2021 00:54
@suhas92 suhas92 requested a review from annelo-msft as a code owner March 5, 2021 00:54
@suhas92
Copy link
Member Author

suhas92 commented Mar 5, 2021

/azp pipelines

@suhas92
Copy link
Member Author

suhas92 commented Mar 5, 2021

/azp run net - textanalytics - tests

@Azure Azure deleted a comment from azure-pipelines bot Mar 5, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@suhas92
Copy link
Member Author

suhas92 commented Mar 5, 2021

/azp run net - textanalytics - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is confusion between a convenience method and a general method. The convenience method is the one where the user provides a list of strings as documents. This is in general easier to use, which is why we call it convenience.
The general method is where the user passes the TextDocumentInput.

To minimize the amount of files, we can use the convenience async method to show automatic polling, and use the convenience sync method to show manual polling. This reduces the number of files from 4 to 2.

As for the general method, we can take advantage and also show stats so this method includes everything.

Because of that the result should be:

  • batch convenience async with automatic polling
  • batch convenience sync with manual polling
  • batch with TextDocumentInput async with automatic polling and with statistics = true
  • batch with TextDocumentInput sync with manual polling
  • cancellation async (u already have)
  • cancellation sync (u already have)

@maririos
Copy link
Member

maririos commented Mar 5, 2021

/azp run net - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@suhas92
Copy link
Member Author

suhas92 commented Mar 5, 2021

#19152

@maririos maririos merged commit af21bab into master Mar 5, 2021
@maririos maririos deleted the sumeh/improve-hc-samples branch March 5, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants