-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Analytics] Improve healthcare samples #19248
Conversation
/azp pipelines |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is confusion between a convenience method and a general method. The convenience method is the one where the user provides a list of strings as documents. This is in general easier to use, which is why we call it convenience.
The general method is where the user passes the TextDocumentInput
.
To minimize the amount of files, we can use the convenience async method to show automatic polling, and use the convenience sync method to show manual polling. This reduces the number of files from 4 to 2.
As for the general method, we can take advantage and also show stats so this method includes everything.
Because of that the result should be:
- batch convenience async with automatic polling
- batch convenience sync with manual polling
- batch with TextDocumentInput async with automatic polling and with statistics = true
- batch with TextDocumentInput sync with manual polling
- cancellation async (u already have)
- cancellation sync (u already have)
sdk/textanalytics/Azure.AI.TextAnalytics/samples/Sample_RecognizeHealthcareEntities.md
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/samples/Sample_RecognizeHealthcareEntities.md
Outdated
Show resolved
Hide resolved
...ure.AI.TextAnalytics/tests/samples/Sample7_AnalyzeHealthcareEntitiesBatchConvenienceAsync.cs
Outdated
Show resolved
Hide resolved
...ure.AI.TextAnalytics/tests/samples/Sample7_AnalyzeHealthcareEntitiesBatchConvenienceAsync.cs
Outdated
Show resolved
Hide resolved
...nalytics/Azure.AI.TextAnalytics/tests/samples/Sample7_AnalyzeHealthcareEntitiesBatchAsync.cs
Outdated
Show resolved
Hide resolved
...nalytics/Azure.AI.TextAnalytics/tests/samples/Sample7_AnalyzeHealthcareEntitiesBatchAsync.cs
Show resolved
Hide resolved
...textanalytics/Azure.AI.TextAnalytics/tests/samples/Sample7_AnalyzeHealthcareEntitiesBatch.cs
Outdated
Show resolved
Hide resolved
...cs/Azure.AI.TextAnalytics/tests/samples/Sample7_AnalyzeHealthcareEntitiesBatchConvenience.cs
Outdated
Show resolved
Hide resolved
…izeHealthcareEntities.md Co-authored-by: Mariana Rios Flores <[email protected]>
…izeHealthcareEntities.md Co-authored-by: Mariana Rios Flores <[email protected]>
…nto sumeh/improve-hc-samples
…zure-sdk-for-net into sumeh/improve-hc-samples
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.