Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom properties of date/time type. #19

Merged
merged 4 commits into from Mar 20, 2012
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,15 @@ public sealed class MessagePropertiesTests
public void MessageProperties()
{
string queueName = UsesUniqueQueueAttribute.QueueName;
DateTimeOffset originalDateTime = new DateTimeOffset(DateTime.UtcNow);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about
DateTimeOffset originalDatetime = DateTimeOffset.Now;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

BrokeredMessageSettings messageSettings = BrokeredMessageSettings.CreateFromText("text/plain", "This is a test.");

messageSettings.Properties.Add("StringProperty", "Test");
messageSettings.Properties.Add("BoolPropertyTrue", true);
messageSettings.Properties.Add("BoolPropertyFalse", false);
messageSettings.Properties.Add("NullProperty", null);
messageSettings.Properties.Add("NumberProperty", 123);
messageSettings.Properties.Add("TimeProperty", originalDateTime);

Configuration.ServiceBus.SendMessageAsync(queueName, messageSettings).AsTask().Wait();
BrokeredMessageInfo message = Configuration.ServiceBus.GetQueueMessageAsync(queueName, TimeSpan.FromSeconds(10)).AsTask().Result;
Expand All @@ -52,13 +54,23 @@ public void MessageProperties()
Assert.True(message.Properties.ContainsKey("BoolPropertyTrue"));
Assert.True(message.Properties.ContainsKey("BoolPropertyFalse"));
Assert.True(message.Properties.ContainsKey("NumberProperty"));
Assert.True(message.Properties.ContainsKey("TimeProperty"));
// The server does not store/return null properties.
Assert.False(message.Properties.ContainsKey("NullProperty"));

Assert.Equal((string)message.Properties["StringProperty"], "Test", StringComparer.Ordinal);
Assert.Equal((bool)message.Properties["BoolPropertyTrue"], true);
Assert.Equal((bool)message.Properties["BoolPropertyFalse"], false);
Assert.Equal(Convert.ToInt32(message.Properties["NumberProperty"]), 123);

// Times must be identical to a second.
DateTimeOffset readDateTime = (DateTimeOffset)message.Properties["TimeProperty"];
Assert.Equal(originalDateTime.Year, readDateTime.Year);
Assert.Equal(originalDateTime.Month, readDateTime.Month);
Assert.Equal(originalDateTime.Day, readDateTime.Day);
Assert.Equal(originalDateTime.Hour, readDateTime.Hour);
Assert.Equal(originalDateTime.Minute, readDateTime.Minute);
Assert.Equal(originalDateTime.Second, readDateTime.Second);
}

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@
<Compile Include="ServiceBus\ServiceBusService.cs" />
<Compile Include="ServiceBus\ServiceConfiguration.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="System" />
</ItemGroup>
<PropertyGroup Condition=" '$(VisualStudioVersion)' == '' ">
<VisualStudioVersion>11.0</VisualStudioVersion>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
using System;
//
// Copyright 2012 Microsoft Corporation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

using System;
using System.Collections.Generic;
using System.Globalization;
using System.Diagnostics;
Expand Down Expand Up @@ -42,7 +57,6 @@ internal CustomPropertiesDictionary(HttpResponseMessage response)
}
else
{
// The string could not be deserialized into Json value; storing raw string data.
Add(key, valueString);
}
}
Expand Down Expand Up @@ -80,9 +94,20 @@ private static object DecodeValue(JsonValue value)
return value.GetNumber();

default:
Debug.Assert(value.ValueType == JsonValueType.String);
return value.GetString();
break;
}

// Extract extra types that are stored as strings.
Debug.Assert(value.ValueType == JsonValueType.String);
string stringValue = value.GetString();
DateTimeOffset dateTime;

if (DateTimeOffset.TryParse(stringValue, out dateTime))
{
return dateTime.ToUniversalTime();
}
return stringValue;

}

/// <summary>
Expand Down Expand Up @@ -134,9 +159,13 @@ private static JsonValue EncodeValue(object value)
{
return JsonValue.CreateStringValue((string)value);
}
else if (IsType<System.DateTimeOffset>(type))
{
return CreateDateTimeValue((DateTimeOffset)value);
}
else
{
//TODO: error message!
//TODO: Error message.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to track this somewhere else, such as issues. It is very easy to get lost on requests like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks gcheng. Created #20

throw new InvalidCastException();
}
}
Expand All @@ -151,5 +180,17 @@ private static bool IsType<T>(Type type)
{
return object.ReferenceEquals(typeof(T), type);
}

/// <summary>
/// Creates a Json string for the given date/time.
/// </summary>
/// <param name="dateTime">Date/time.</param>
/// <returns>Json string value with the date/time.</returns>
private static JsonValue CreateDateTimeValue(DateTimeOffset dateTime)
{
dateTime = dateTime.ToUniversalTime();
string dateTimeString = dateTime.ToString("r");
return JsonValue.CreateStringValue(dateTimeString);
}
}
}