-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom properties of date/time type. #19
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,19 @@ | ||
using System; | ||
// | ||
// Copyright 2012 Microsoft Corporation | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
|
||
using System; | ||
using System.Collections.Generic; | ||
using System.Globalization; | ||
using System.Diagnostics; | ||
|
@@ -42,7 +57,6 @@ internal CustomPropertiesDictionary(HttpResponseMessage response) | |
} | ||
else | ||
{ | ||
// The string could not be deserialized into Json value; storing raw string data. | ||
Add(key, valueString); | ||
} | ||
} | ||
|
@@ -80,9 +94,20 @@ private static object DecodeValue(JsonValue value) | |
return value.GetNumber(); | ||
|
||
default: | ||
Debug.Assert(value.ValueType == JsonValueType.String); | ||
return value.GetString(); | ||
break; | ||
} | ||
|
||
// Extract extra types that are stored as strings. | ||
Debug.Assert(value.ValueType == JsonValueType.String); | ||
string stringValue = value.GetString(); | ||
DateTimeOffset dateTime; | ||
|
||
if (DateTimeOffset.TryParse(stringValue, out dateTime)) | ||
{ | ||
return dateTime.ToUniversalTime(); | ||
} | ||
return stringValue; | ||
|
||
} | ||
|
||
/// <summary> | ||
|
@@ -134,9 +159,13 @@ private static JsonValue EncodeValue(object value) | |
{ | ||
return JsonValue.CreateStringValue((string)value); | ||
} | ||
else if (IsType<System.DateTimeOffset>(type)) | ||
{ | ||
return CreateDateTimeValue((DateTimeOffset)value); | ||
} | ||
else | ||
{ | ||
//TODO: error message! | ||
//TODO: Error message. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be better to track this somewhere else, such as issues. It is very easy to get lost on requests like this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks gcheng. Created #20 |
||
throw new InvalidCastException(); | ||
} | ||
} | ||
|
@@ -151,5 +180,17 @@ private static bool IsType<T>(Type type) | |
{ | ||
return object.ReferenceEquals(typeof(T), type); | ||
} | ||
|
||
/// <summary> | ||
/// Creates a Json string for the given date/time. | ||
/// </summary> | ||
/// <param name="dateTime">Date/time.</param> | ||
/// <returns>Json string value with the date/time.</returns> | ||
private static JsonValue CreateDateTimeValue(DateTimeOffset dateTime) | ||
{ | ||
dateTime = dateTime.ToUniversalTime(); | ||
string dateTimeString = dateTime.ToString("r"); | ||
return JsonValue.CreateStringValue(dateTimeString); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
DateTimeOffset originalDatetime = DateTimeOffset.Now;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK