Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(modelsRepo): Initial commit: Azure.Iot.ModelsRepository #18998

Merged
merged 22 commits into from
Feb 25, 2021

Conversation

azabbasi
Copy link
Contributor

No description provided.

azabbasi and others added 13 commits February 11, 2021 16:37
* Add support for recorded tests.

* Make strings constants

* Update file names to include plural models
* Small refactoring

* Fix variable casing.
* Refactor ModelQuery.
* Resolve PR feedback.
* Combine constant files.
* Remove ResolverException in favor of RequestFailedException. Adds more docstrings.
* Resolve PR feedback.
* Add first draft of readme.
* Add comment for dtmi validation.
* Wave of addressing feedback.
* Code word fix.
* Fix links.
* Add diagnostic event info.
* Source link specifically pointing to 'src' folder.
.github/CODEOWNERS Outdated Show resolved Hide resolved
@azabbasi azabbasi marked this pull request as ready for review February 24, 2021 22:19
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@azabbasi
Copy link
Contributor Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor Author

/azp run net - modelsrepository - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mitchdenny
Copy link
Contributor

/azp run net - modelsrepository

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor Author

/azp run net - modelsrepository

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor Author

/azp run net - modelsrepository

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor Author

/azp run net - modelsrepository

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor Author

/azp run net - modelsrepository

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi azabbasi merged commit 733e79a into master Feb 25, 2021
@azabbasi azabbasi deleted the feature/modelsRepo branch February 25, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants