Add test coverage for MHSM and local cryptography #18902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Azure#16713 Resolves Azure#18864 Temporarily works around Azure#18800 by trimming leading zeros coming back from the service after updating a key and before asserting equality.
ghost
added
the
|
@schaabs @christothes @pakrym the PR is not actually that big - only 10 files, and mostly small changes - if you look at the non-recordings: https://github.com/Azure/azure-sdk-for-net/pull/18902/files?file-filters%5B%5D=.cs&file-filters%5B%5D=.csproj |
heaths
commented
Feb 21, 2021
| { | ||
| s_rsaFactory = p => | ||
| { | ||
| RSA rsa = RSA.Create(); |
There was a problem hiding this comment.
On Framework, this won't create the CNG version of RSA, which later won't support RSA-OAEP-SHA256.
christothes
reviewed
Feb 22, 2021
sdk/keyvault/Azure.Security.KeyVault.Keys/tests/Azure.Security.KeyVault.Keys.Tests.csproj
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/tests/KeysTestBase.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/tests/ManagedHsmCryptographyClientLiveTests.cs
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Secrets/tests/SecretClientLiveTests.cs
Show resolved
Hide resolved
pakrym
reviewed
Feb 22, 2021
pakrym
reviewed
Feb 22, 2021
sdk/keyvault/Azure.Security.KeyVault.Keys/tests/ManagedHsmCryptographyClientLiveTests.cs
Show resolved
Hide resolved
pakrym
approved these changes
Feb 22, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
May 24, 2022
Merge Cognitive Services - Language pillar version 2022-05-15-preview to main (Azure#19186) * Updated May-1 preview to include changes from March-1 preview (Azure#18580) * Updated May-1 preview to include changes from March-1 preview * Fixed a missed api version update in an example file Co-authored-by: Abigail Hartman <[email protected]> * [Language API 2022-05-01-Preview]Conversation API Async - Conversational Summarization and Conversational PII (Azure#17847) * Adds base for updating Language from version preview/2022-02-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * [Language API 2022-04-01-Preview] Feature conversation PII redaction and issue resolution summarization * Add Issue Resolution Summary * Address comments * address pretty chek and spell check issues * address file name mismatch issue * typo * Add IRD updates * Add IRD Schema changes * Response Files content update * Address feedback * Address PR comments * Address comments * Add the May API version * Address comments * Remove 04-01 and address comments * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/textanalytics.json Co-authored-by: Heath Stewart <[email protected]> * Address feedback V-1. * Address all comments expect model + enum descriptions * Fx validations * Missed files * Conversation Item modality issue * Update PII Task * Address Spec validation errors * Updates * Fix PII issues * Add readonly * Update schema * Updates * Bring back Text Conversation Item * Update example * Space in Json * Address comments * Address one more comments * Fix model validation * Fix * Update spec * Address comments * Move requestStatistics, prebuiltResult, error and warnings object to common * Address circular dependency Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * Rename version from 2022-05-01-preview to 2022-05-15-preview (Azure#18737) * Update CLU swagger (Azure#18739) Co-authored-by: Chong Tang <[email protected]> * Use azure-sdk-for-net-track2 for validation (Azure#18755) * Bidishac/update field description (#18787) * Update the messaging on the parameter type * Update the documentation of the redactionSource field * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * Unify the runtime and authoring APIs (Azure#18837) * unifying single classification and multi classification to return array of class (Azure#18902) * Renaming in 2022-05-15-preview (Azure#18929) Co-authored-by: Chong Tang <[email protected]> * Rename 'summary' in summaryAspects to 'issue' (Azure#18941) * Rename 'summary' in summaryAspects to 'issue' * Merge issues * Update model version value * Merge 2022-05-01-GA authoring updates and "LUIS" string case update into 2022-05-15-preview branch (Azure#18943) * Merge 2022-05-01-GA files changes into 2022-05-15-preview branch * Address Avocado issues and revert case update for Luis * Add the missing error codes * Fix avocado * Avocado fix * Add api-version parameter to cancel job endpoint (Azure#18986) * Add api-version parameter to cancel job endpoint * Fix taskState and jobState * Revert "Fix taskState and jobState" This reverts commit 148dd2183249add89a090721db36a14c2b15d9bd. * Update LUIS to Luis in model names (Azure#19012) * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (Azure#19031) Co-authored-by: Chong Tang <[email protected]> * Added fhir feature updates to 2022-05-15-preview (Azure#19092) Co-authored-by: Abigail Hartman <[email protected]> * Add cancel endpoint for conversations (Azure#19025) * Add cancel endpoint for conversations * Update examples path * Make the input for transcriptConversationItem optional * Bidishac/update enum name (Azure#19149) * Update name to CreditCard * Update entity categories for PII for build * Keep SSN * Revert "Keep SSN" This reverts commit 77a92119ebd71cf5d5c7f201d402514756289ec2. * Update readme.md Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Bidisha Chakraborty <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Mohamed Abbas <[email protected]> Co-authored-by: Nourhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16713
Resolves #18864
Temporarily works around #18800 by trimming leading zeros coming back from the service after updating a key and before asserting equality.