Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AlertModificationEvent.cs #11761

Closed
wants to merge 1 commit into from
Closed

Update AlertModificationEvent.cs #11761

wants to merge 1 commit into from

Conversation

orieldar
Copy link
Contributor

@orieldar orieldar commented May 4, 2020

Added missing Alert Modification Events.
Code reviewed and all Tests Passed:
image

- Added missing Alert Modification Events
@isra-fel
Copy link
Member

isra-fel commented May 6, 2020

Hi @orieldar was this change written by hand?
We shouldn't modify anything under generate/ folder or it will be overwritten next time.
The right way is to update your openapi spec and generate SDK based on that. Here's the process of SDK Generation from Updated Spec

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels May 6, 2020
@orieldar
Copy link
Contributor Author

orieldar commented May 6, 2020

Hi @isra-fel , thanks will do.

@orieldar orieldar closed this May 6, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants