Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Security Center client #11704

Merged
merged 9 commits into from
May 6, 2020
Merged

Updating Security Center client #11704

merged 9 commits into from
May 6, 2020

Conversation

MatanShabtay
Copy link
Contributor

Regenerating SecurityCenter client from swagger.

APIs added:

  1. apdativeNetworkHardenings
    2.allowedConnections
    3.topology

Added UTs for operations without tests such as AdaptiveApplicationControls

@MatanShabtay
Copy link
Contributor Author

@isra-fel / @erich-wang I will appreciate your review here

@isra-fel
Copy link
Member

isra-fel commented May 6, 2020

Since Microsoft.Azure.Management.SecurityCenter 2.0.0 was released, Matan, I think you need to update the versions in Microsoft.Azure.Management.SecurityCenter.csproj and AssemblyInfo.cs, plus the release notes in csproj

Others LGTM.
Sorry about the inconvenience again.

@MatanShabtay
Copy link
Contributor Author

Since Microsoft.Azure.Management.SecurityCenter 2.0.0 was released, Matan, I think you need to update the versions in Microsoft.Azure.Management.SecurityCenter.csproj and AssemblyInfo.cs, plus the release notes in csproj

Others LGTM.
Sorry about the inconvenience again.

Done

@isra-fel isra-fel reopened this May 6, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. Waiting for CI :shipit: labels May 6, 2020
@isra-fel isra-fel self-assigned this May 6, 2020
@isra-fel isra-fel merged commit 434b2ae into Azure:master May 6, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Nov 20, 2020
Microsoft.Compute: Include CloudServices Resource Swagger under API Version 2020-10-01-preview (Azure#11704)

Co-authored-by: Sanchit Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants