Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IotCentral] Update C# sdk, Change error to be CloudException, and remove regex check for IOTC app #10322

Merged
merged 3 commits into from
Mar 12, 2020
Merged

[IotCentral] Update C# sdk, Change error to be CloudException, and remove regex check for IOTC app #10322

merged 3 commits into from
Mar 12, 2020

Conversation

kawayiboy
Copy link
Contributor

@kawayiboy kawayiboy commented Mar 5, 2020 •
edited
Loading

[IotCentral] Update C# sdk, Change error to be CloudException, and remove regex check for IOTC app

@kawayiboy kawayiboy changed the title Update C# sdk, Change error to be CloudException, and remove regex ch… [IotCentral] Update C# sdk, Change error to be CloudException, and remove regex check for IOTC app Mar 5, 2020
@isra-fel isra-fel self-assigned this Mar 6, 2020
@isra-fel
Copy link
Member

isra-fel commented Mar 6, 2020

Please remove file sdk/iotcentral/Microsoft.Azure.Management.IotCentral/src/Generated/code-model-v1 and put the link of related swagger review PR in the comments. Thanks!

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. Do Not Merge labels Mar 6, 2020
@kawayiboy
Copy link
Contributor Author

Here is the related swagger change: Azure/azure-rest-api-specs#8395, it's ok to merge now, the sdk have been published, thanks

@isra-fel isra-fel merged commit d59f891 into Azure:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

Labels
Do Not Merge Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawayiboy @isra-fel