Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers #34779

Closed
archerzz opened this issue Mar 8, 2023 · 0 comments · Fixed by #34780
Closed

[FEATURE REQ] Replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers #34779

archerzz opened this issue Mar 8, 2023 · 0 comments · Fixed by #34780
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Mgmt This issue is related to a management-plane library.

Comments

@archerzz
Copy link
Member

archerzz commented Mar 8, 2023 •
edited
Loading

Library name

All

Please describe the feature.

Description

We should replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers because:

  • On Roslyn analyzer pages, FxCopAnalyzers are obsolete and it's recommended to use NetAnalyzers
  • Recently we got random reports of CA1825 error which cannot be reproduced on everyone's machine. Initial analysis indicates it's a false positive and the solution is to use NetAnalyzers. See here:
    image
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 8, 2023
archerzz added a commit to archerzz/azure-sdk-for-net that referenced this issue Mar 8, 2023
@archerzz
build(analyzer): replace FxCopAnalyzers with NetAnalyzers
98acb22 
`FxCopAnalyzers` is obsolete and it's reocmmended to use `NetAnalyzers`. See correponding issue for details.

resolve Azure#34779
@archerzz archerzz mentioned this issue Mar 8, 2023
Merged
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Mgmt This issue is related to a management-plane library. EngSys This issue is impacting the engineering system. labels Mar 8, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 8, 2023
archerzz added a commit that referenced this issue Mar 21, 2023
@archerzz
build(analyzer): replace FxCopAnalyzers with NetAnalyzers (#34780)
6bf7b23 
`FxCopAnalyzers` is obsolete and it's reocmmended to use `NetAnalyzers`. See correponding issue for details.

resolve #34779
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(analyzer): replace FxCopAnalyzers with NetAnalyzers archerzz/azure-sdk-for-net
2 participants
@archerzz @jsquire