Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] [Pending service update] [Pre-GA] Finalize cloud configuration API #21603

Closed
annelo-msft opened this issue Jun 4, 2021 · 3 comments · Fixed by #23141
Closed

[ACR] [Pending service update] [Pre-GA] Finalize cloud configuration API #21603

annelo-msft opened this issue Jun 4, 2021 · 3 comments · Fixed by #23141
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Jun 4, 2021

The service will be making changes to how users can authenticate with it. Given this, we'll want to revisit and potentially replace the AuthorizationScope property on ContainerRegistryClientOptions with an API that

(in order of preference)

  • (if General ACR scope enables this) makes it unnecessary for customer to specify cloud
  • Arch board guidance specifies how users can indicate which cloud in a Track 2 consistent way
  • If the service provides two permissions models with different scopes associated with them, we would provide an API that communicates the differences between the two models, and either guides the user to choose the appropriate scope, or specifies it for them.

[See updated API description below]

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Container Registry labels Jun 4, 2021
@annelo-msft annelo-msft added this to the [2021] July milestone Jun 4, 2021
@annelo-msft annelo-msft added the blocking-release Blocks release label Jun 4, 2021
@annelo-msft annelo-msft changed the title Finalize cloud configuration API [ACR] [Pre-GA] Finalize cloud configuration API Jun 21, 2021
@annelo-msft
Copy link
Member Author

Per conversations with @schaabs and @AlexGhiondea, we will make the following changes to the API:

  • Provide an Audience property in ClientOptions, replacing the AuthorizationScope property from the Beta 3 API
  • Audience is an extensible enum, listing the known clouds, but user can override with a string if needed
  • If Audience is set, client library will append /.default to Audience to specify the default scope
  • Audience will default to data-plane scope root, which should be common across clouds

@annelo-msft
Copy link
Member Author

Moving to August per internal discussion.

@annelo-msft annelo-msft changed the title [ACR] [Pre-GA] Finalize cloud configuration API [ACR] [Pending service team update ] [Pre-GA] Finalize cloud configuration API Jul 7, 2021
@annelo-msft annelo-msft changed the title [ACR] [Pending service team update ] [Pre-GA] Finalize cloud configuration API [ACR] [Pending service update] [Pre-GA] Finalize cloud configuration API Jul 7, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Nov 22, 2022
{containerregistry} Fix Azure#21603: Mention anonymous pull access is a preview feature, available in the Standard and Premium service tiers (Azure#21623)

Fixes Azure/azure-rest-api-specs#21603
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant