Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[winmd servicebus] content type should not be explicitly required while creating a brokeredmessage #21

Closed
deepakverma opened this issue Mar 20, 2012 · 2 comments

Comments

@deepakverma
Copy link
Contributor

winmd code: https://github.com/WindowsAzure/azure-sdk-for-net/blob/dev/microsoft-azure-servicelayer/Microsoft.WindowsAzure.ServiceLayer/ServiceBus/BrokeredMessageSettings.cs

current: public static BrokeredMessageSettings CreateFromText(string contentType, string messageText)

proposed: public static BrokeredMessageSettings CreateFromText(string messageText)

code changes required:

  • removing exception handling for null content type
  • in _content = new StringContent(messageText, Encoding.UTF8); (which would make it default to text/plain)
  • set content type implementation

thx.

@toddysm
Copy link

toddysm commented Mar 21, 2012

Can we check what other languages do as default content type and set this implicitly? We should take the proposal above once we agree on the default content type.

@aliakb
Copy link

aliakb commented Apr 10, 2012

Specifying content type is no longer required.

@aliakb aliakb closed this as completed Apr 10, 2012
chuanboz pushed a commit to chuanboz/HDInsight that referenced this issue Feb 20, 2015
huangpf added a commit that referenced this issue Jun 18, 2015
yugangw-msft pushed a commit that referenced this issue Jul 9, 2015
jethibau pushed a commit to jethibau/azure-sdk-for-net that referenced this issue Aug 2, 2018
jsquire pushed a commit to jsquire/azure-sdk-for-net that referenced this issue Mar 12, 2019
* Adding StyleCop settings file, and refactoring accordingly

* Reverting the addition of access modifiers in unit tests

* removing unnecessary internal
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this issue Jun 10, 2019
* Adding StyleCop settings file, and refactoring accordingly

* Reverting the addition of access modifiers in unit tests

* removing unnecessary internal
isra-fel pushed a commit that referenced this issue Jun 18, 2020
* Youri/compute (#16)

* add compute test

* fix tetbas

* add all recorded files

* change compute case

* fix some json issue

* change csproj

* update test cases

* update test cases

* update test cases

* minor update

* update test cases

* Fix for location initialize (#20)

* change DiskRPTest Location[C (#21)

* code refactoring

* Re-record GalleryImageVersion_CRUD_Tests (#22)

* Fix for location initialize

* Re-record GalleryImageVersion_CRUD_Tests

* Youri/compute.test (#23)

* change DiskRPTest Location[C

* add OSProfile json

* update change log and disable test TestVMScaleSetServiceFabric

Co-authored-by: Youri970410 <[email protected]>
Co-authored-by: Youri <[email protected]>
Co-authored-by: Harvey Chen <[email protected]>
prmathur-microsoft pushed a commit that referenced this issue Jul 8, 2020
* Youri/compute (#16)

* add compute test

* fix tetbas

* add all recorded files

* change compute case

* fix some json issue

* change csproj

* update test cases

* update test cases

* update test cases

* minor update

* update test cases

* Fix for location initialize (#20)

* change DiskRPTest Location[C (#21)

* code refactoring

* Re-record GalleryImageVersion_CRUD_Tests (#22)

* Fix for location initialize

* Re-record GalleryImageVersion_CRUD_Tests

* Youri/compute.test (#23)

* change DiskRPTest Location[C

* add OSProfile json

* update change log and disable test TestVMScaleSetServiceFabric

Co-authored-by: Youri970410 <[email protected]>
Co-authored-by: Youri <[email protected]>
Co-authored-by: Harvey Chen <[email protected]>
sharathmalladi pushed a commit to sharathmalladi/azure-sdk-for-net that referenced this issue Feb 28, 2022
Mohit-Chakraborty pushed a commit that referenced this issue Mar 1, 2022
* 12767912: Add isLocalInference in the public SDK

* Rename the variable

* Thick clent feature (#5)

* 12767907: Add a package dependency on Microsoft.RL

* Add RankProcessor

* Remove unused file

* Remove some key

* Toggle commented codes so that most tests can pass

* Getting the required config details for rankprocessor to enable livemode

* Updating the wrong variable name

* Cleanup

* Revert "12767907: Add a package dependency on Microsoft.RL"

This reverts commit c586920.

* Revert "Add RankProcessor"

This reverts commit 43967d3.

* Revert "Remove unused file"

This reverts commit 1e400a8.

* Revert "Toggle commented codes so that most tests can pass"

This reverts commit 7ec50ec.

* Delete DisposeHelper.cs

* Revert "Revert "12767907: Add a package dependency on Microsoft.RL""

This reverts commit d6df6b5.

* Cleanup after reverting

* generating client configuration using autorest

* Revert "generating client configuration using autorest"

This reverts commit 6b75695.

* Configuration details for livemodel

* cleanup

* cleanup

* Added ToDo comments

* correct the version in endpoints

Co-authored-by: Tejaswi Paruchuri <[email protected]>
Co-authored-by: Tparuchuri <[email protected]>

* 12768045: Add rank processor for single slot (#3)

Add RankProcessor

Remove unused file

Remove some key

Toggle commented codes so that most tests can pass

RankProcessor is working. Still need to clean up the codes

Add test json files

only construct LiveModel when localInference is true

Move rankprocessor to under model

Add latest generated files from autorest

Add autogenerated files from autorest

Fix the setting in DecisionContext

Remove wrong comment

Revert unexpected auto-generated file changes

Addressed a comment

Move suppression to GlobalSuppressions.cs

Remove the decoration in MultiSlotClient.cs

Refactor rankProcessor so that the actions is not modified and restored;
added a converter between sdk and Rl.Net; replace Newtonsoft.json with
System.Text.Json

Address comments

Refactor RlObjuectConverter; remove some unneeded setters, etc.

Added unit tests for RlObjectConverter, DecisionContext,
JsonRawStringListConverter

Remove unused using

* 13009290: Create RankProcessor class to Azure Personalizer client library for .NET for multi slot (#7)

* 13009290: Create RankProcessor class to Azure Personalizer client
              library for .NET for multi slot

* Address comments

* Subsampling

* Cleanup and added tests

* Cleanup and added tests

* cleanup

* cleanup

* Single SubSample rate

* Cleanup

* Cleanup

* Variable name

* 13192221: Point to the Rl.Net nuget package from SDK dev drop (#9)

* Adding test code for Model/Put api and moving to preview.3

* Johnhuang/13216589 reward activate local inference api (#10)

* Update API view file

* 13216589: Add local inference reward api
13216590: Add local inference activate api

* Fix the comments

* Remove IsDisposed method

* Revert "Update API view file"

This reverts commit 0a4dcbf.

* Remove MultiSlotClient class as it is never used

* Add more change after other PRs were merged

* Revert "Add more change after other PRs were merged"

This reverts commit 35a3120.

* 13225147: Update API view file for thick client (#11)

* 13225147: Update API view file for thick client

* Remove some suppressing warning

* Add more changes after 2 PRs were merged

* lazy load rank processor, refresh config  and relaod token on expiry (#12)

* lazy load rank processor, refresh config  and relaod token on expiry

* Comments & Cleanup

* Cleanup

* Addressed comments

* Cleanup

* Fix conflict

Co-authored-by: John Huang <[email protected]>

* 13309375: Improve the tests by mocking LiveModel when test mode is (#14)

* 13309375: Improve the tests by mocking LiveModel when test mode is
	  Playback but using real LiveModel when test mode is Live

* Change some public classes to private

* Address those comments in the main PR

* Update Microsoft.RL version

* Rename some properties

* Update Microsoft.RL version

* Fix spelling check

* Remove the unneeded warning

* Update live model config

* Use similar method names for export and import apis

* Johnhuang/13170630 address thick client sdk review (#18)

* 13170630: Address comments from SDK review

* Update API view file

* Remove unnecessary file under Gerated folder

* Add more test for RLObjectConverter

* Remove unused parameter

* Remove unneeded comment

* Update recording sessions for tests that were changed in earlier commit. (#19)

Co-authored-by: Personalizer Team <[email protected]>

* Update api view file after model api change (#20)

* Rename modelStream to modelBody (#21)

* Update Microsoft.RL version

* 13678440: Some cosmetic change to address comments from DotNet team (#22)

* Update method names for Export/Import models as per suggestions. (#23)

* Update method names for Export/Import models as per suggestions.

* Updates after running codecheck.ps1 script

Co-authored-by: Personalizer Team <[email protected]>

Co-authored-by: Tejaswi Paruchuri <[email protected]>
Co-authored-by: Tparuchuri <[email protected]>
Co-authored-by: Personalizer Team <[email protected]>
Co-authored-by: Sharath Malladi <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants