All credentials have parameterless ctor (#43962)

Azure · May 15, 2024 · 9637250 · 9637250
1 parent 2866346
commit 9637250
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs b/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs
@@ -115,6 +115,7 @@ public BrowserCustomizationOptions() { }
     }
     public partial class ChainedTokenCredential : Azure.Core.TokenCredential
     {
+        protected ChainedTokenCredential() { }
         public ChainedTokenCredential(params Azure.Core.TokenCredential[] sources) { }
         public override Azure.Core.AccessToken GetToken(Azure.Core.TokenRequestContext requestContext, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
         public override System.Threading.Tasks.ValueTask<Azure.Core.AccessToken> GetTokenAsync(Azure.Core.TokenRequestContext requestContext, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
@@ -180,6 +181,7 @@ public CredentialUnavailableException(string message, System.Exception innerExce
     }
     public partial class DefaultAzureCredential : Azure.Core.TokenCredential
     {
+        protected DefaultAzureCredential() { }
         public DefaultAzureCredential(Azure.Identity.DefaultAzureCredentialOptions options) { }
         public DefaultAzureCredential(bool includeInteractiveCredentials = false) { }
         public override Azure.Core.AccessToken GetToken(Azure.Core.TokenRequestContext requestContext, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }

diff --git a/sdk/identity/Azure.Identity/src/Credentials/ChainedTokenCredential.cs b/sdk/identity/Azure.Identity/src/Credentials/ChainedTokenCredential.cs
@@ -37,9 +37,9 @@ public class ChainedTokenCredential : TokenCredential
         private readonly TokenCredential[] _sources;
 
         /// <summary>
-        /// Constructor for instrumenting in tests
+        /// Protected constructor for <see href="https://aka.ms/azsdk/net/mocking">mocking</see>.
         /// </summary>
-        internal ChainedTokenCredential()
+        protected ChainedTokenCredential()
         {
             _sources = Array.Empty<TokenCredential>();
         }

diff --git a/sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredential.cs b/sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredential.cs
@@ -64,7 +64,10 @@ public class DefaultAzureCredential : TokenCredential
 
         internal TokenCredential[] _sources;
 
-        internal DefaultAzureCredential() : this(false) { }
+        /// <summary>
+        /// Protected constructor for <see href="https://aka.ms/azsdk/net/mocking">mocking</see>.
+        /// </summary>
+        protected DefaultAzureCredential() : this(false) { }
 
         /// <summary>
         /// Creates an instance of the DefaultAzureCredential class.

diff --git a/sdk/identity/Azure.Identity/tests/AzurePipelinesCredentialTests.cs b/sdk/identity/Azure.Identity/tests/AzurePipelinesCredentialTests.cs
@@ -40,7 +40,8 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 PlanId = "myplan",
                 JobId = "myjob",
                 TeamProjectId = "myteamproject",
-                SystemAccessToken = "mytoken"
+                SystemAccessToken = "mytoken",
+                HubName = "myhub",
             };
             if (config.Transport != null)
             {