Skip to content

Commit

Permalink
fix issue #34745 (#34838)
Browse files Browse the repository at this point in the history
* fix issue #34745

* update changelog

* add message for the new property
  • Loading branch information
ArcturusZhang authored Mar 14, 2023
1 parent 5b614d0 commit 5f08833
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 11 deletions.
2 changes: 2 additions & 0 deletions sdk/websites/Azure.ResourceManager.AppService/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Fixed issue #34745. Introduced new property `RelayArmId` in `HybridConnectionData` class to replace the property `RelayArmUri` with a wrong type `Uri`.

### Other Changes

## 1.0.1 (2023-02-20)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,9 @@ public HybridConnectionData() { }
public string Hostname { get { throw null; } set { } }
public string Kind { get { throw null; } set { } }
public int? Port { get { throw null; } set { } }
public Azure.Core.ResourceIdentifier RelayArmId { get { throw null; } set { } }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
[System.ObsoleteAttribute("This property is obsolete and will be removed in a future release, please use `RelayArmId` instead", false)]
public System.Uri RelayArmUri { get { throw null; } set { } }
public string RelayName { get { throw null; } set { } }
public string SendKeyName { get { throw null; } set { } }
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

#nullable disable

using System;
using System.ComponentModel;

namespace Azure.ResourceManager.AppService
{
public partial class HybridConnectionData
{
/// <summary> The ARM URI to the Service Bus relay. </summary>
[Obsolete("This property is obsolete and will be removed in a future release, please use `RelayArmId` instead", false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public Uri RelayArmUri { get; set; }
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ rename-mapping:
WebAppStackCollection: WebAppStackListResult
WebJobCollection: WebJobCListResult
WorkerPoolCollection: AppServiceWorkerPoolListResult
HybridConnection.properties.relayArmUri: relayArmId|arm-id

prepend-rp-prefix:
- ApiDefinitionInfo
Expand Down

0 comments on commit 5f08833

Please sign in to comment.