Skip to content

Commit

Permalink
[Service Bus] Model factory comments (#43276)
Browse files Browse the repository at this point in the history
* [Service Bus] Model factory comments

The focus of these changes is to add doc comments
to the `ServiceBusModelFactory` members, specifically
helping callers to understand what model properties
each argument populates.  Because some of the parameter
names differ from the associated model property names,
there has been some confusion.
---------

Co-authored-by: JoshLove-msft <[email protected]>
  • Loading branch information
jsquire and JoshLove-msft authored Apr 8, 2024
1 parent 2695e6f commit 0f3696b
Show file tree
Hide file tree
Showing 2 changed files with 121 additions and 11 deletions.
3 changes: 3 additions & 0 deletions sdk/servicebus/Azure.Messaging.ServiceBus/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@
### Bugs Fixed

- Fixed an edge case where a cancellation token signaled while waiting for a throttling delay would cause a failure to reset state and service operations would continue to apply the throttle delay going forward. ([#42952](https://github.com/Azure/azure-sdk-for-net/issues/42952))

- Fixed an issue where the `ServiceBusSessionProcessor` was not respecting `ServiceBusSessionProcessorOptions.MaxConcurrentCallsPerSession` when `ServiceBusSessionProcessorOptions.SessionIds` was set to a value. ([#43157](https://github.com/Azure/azure-sdk-for-net/pull/43157))

### Other Changes

- Added missing documentation for `ServiceBusModelFactory` members with a focus on clarifying what model properties each parameter to the factory methods will populate. In some cases, parameter names differ from the associated model properties, causing confusion. ([#42772](https://github.com/Azure/azure-sdk-for-net/issues/42772))

## 7.17.4 (2024-03-05)

### Bugs Fixed
Expand Down
Loading

0 comments on commit 0f3696b

Please sign in to comment.