Skip to content

Commit

Permalink
Fix typo in Azure.Core ClientOptions.cs comments. Fix typo and use `E…
Browse files Browse the repository at this point in the history
…ntra ID` term in Azure.AI.OpenAI readme. (#41908)

- Fix typo in comments for class sdk/core/Azure.Core/src/ClientOptions.cs
- Fix missing dot in sdk/openai/Azure.AI.OpenAI/README.md
- Use the term Entra ID instead of Azure Active Directory in sdk/openai/Azure.AI.OpenAI/README.md
  • Loading branch information
dargilco authored Feb 12, 2024
1 parent 10db9b6 commit 0b34e95
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/src/ClientOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protected ClientOptions(): this(Default, null)
}

/// <summary>
/// Creates a new instance of <see cref="ClientOptions"/> with the specificed <see cref="DiagnosticsOptions"/>.
/// Creates a new instance of <see cref="ClientOptions"/> with the specified <see cref="DiagnosticsOptions"/>.
/// </summary>
/// <param name="diagnostics"><see cref="DiagnosticsOptions"/> to be used for <see cref="Diagnostics"/>.</param>
protected ClientOptions(DiagnosticsOptions? diagnostics)
Expand Down
6 changes: 3 additions & 3 deletions sdk/openai/Azure.AI.OpenAI/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ OpenAIClient client = useAzureOpenAI
: new OpenAIClient("your-api-key-from-platform.openai.com");
```

#### Create OpenAIClient with an Azure Active Directory Credential
#### Create OpenAIClient with a Microsoft Entra ID Credential

Client subscription key authentication is used in most of the examples in this getting started guide, but you can also authenticate with Azure Active Directory using the [Azure Identity library][azure_identity]. To use the [DefaultAzureCredential][azure_identity_dac] provider shown below,
Client subscription key authentication is used in most of the examples in this getting started guide, but you can also authenticate with Microsoft Entra ID (formerly Azure Active Directory) using the [Azure Identity library][azure_identity]. To use the [DefaultAzureCredential][azure_identity_dac] provider shown below,
or other credential providers provided with the Azure SDK, please install the Azure.Identity package:

```dotnetcli
Expand Down Expand Up @@ -380,7 +380,7 @@ Additionally: if you would like to control the behavior of tool calls, you can u
- Providing a reference to a named function definition or function tool definition, as below, will instruct the model
to restrict its response to calling the corresponding tool. When calling tools in this configuration, response
`ChatChoice` instances will report a `FinishReason` of `CompletionsFinishReason.Stopped` and the corresponding
`ToolCalls` property will be populated Note that, because the model was constrained to a specific tool, it does
`ToolCalls` property will be populated. Note that, because the model was constrained to a specific tool, it does
**NOT** report the same `CompletionsFinishReason` value of `ToolCalls` expected when using
`ChatCompletionsToolChoice.Auto`.

Expand Down

0 comments on commit 0b34e95

Please sign in to comment.