[core-http] fix browser tests on Firefox #9091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 1) on Firefox user agent string contains more than two fields: "core-http/1.1.3 OS/WindowsNT 10.0; Win64; x64" while on Chrome it has just two: "core-http/1.1.3 OS/Win32" Changed to verify it has at least two fields. Issue 2) Most likely either Chrome has a bug, or behavior of dates before January 1, 1970 is not well defined. For the date Tue, Jan 1 0001 00:00:00 GMT, Chrome sets the year to be 2001, while Firefox keeps the year as 0001. Changed to use another date in the test. Issue 3) The error message when parsing xml with an input of undefined or null is different between Chrome and Firefox. Changed to pass on either one.
jeremymeng
requested review from
bterlson,
chradek,
daviwil and
xirzec
as code owners
xirzec
approved these changes
May 26, 2020
| @@ -286,9 +286,9 @@ describe("msrest", function() { | |||
| required: false, | |||
| serializedName: "DateTimeRfc1123" | |||
| }; | |||
| const rfc = new Date("Mon, 01 Jan 0001 00:00:00 GMT"); | |||
| const rfc = new Date("Thu, 01 Jan 3001 00:00:00 GMT"); | |||
There was a problem hiding this comment.
bizarre to me that we're worried about times thousands of years from the present
There was a problem hiding this comment.
yeah, I will update to some date in 2020
| error.message.indexOf("Document is empty"), | ||
| -1, | ||
| `error.message ("${error.message}") should have contained "Document is empty"` | ||
| assert.ok( |
There was a problem hiding this comment.
is it worth checking this message? Should we just assert that it throws?
There was a problem hiding this comment.
I wanted to keep the old behavior of verifying that it's a parsing error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1) on Firefox user agent string contains more than two
fields:
"core-http/1.1.3 OS/WindowsNT 10.0; Win64; x64"
while on Chrome it has just two:
"core-http/1.1.3 OS/Win32"
Changed to verify it has at least two fields.
Issue 2) Most likely either Chrome has a bug, or behavior of dates
before January 1, 1970 is not well defined. For the date Tue, Jan 1
0001 00:00:00 GMT, Chrome sets the year to be 2001, while Firefox
keeps the year as 0001.
Changed to use another date in the test.
Issue 3) The error message when parsing xml with an input of undefined
or null is different between Chrome and Firefox.
Changed to pass on either one.