[Storage] Remove retries for the tests

[HarshaNalluru]

Removing mocha retry configs for both the node tests and the browser tests
(Meaning, if a test fails, it won't be re-run)

[ramya-rao-a]

Any links to prior discussions on why we are removing the retries?

[HarshaNalluru]

More Info

#4196

In the current retry mechanism for the tests, we have enabled mocha retries at the test-suite level which might hide flaky tests and we might potentially lose any hidden bugs with the SDK or even with the service.
In case we are addressing the flaky connectivity issues by retrying, the ideal solution is to be scoping it better(like retrying that specific request).

@mikeharder is currently working on getting the live tests to succeed at least 90% without the retries for tests.

[mikeharder]

Just a question, but why are retries and timeout specified in both karma.conf.js and the mocha command-line? When is karma.conf.js used?

This PR is a good start, but it should not be merged until we are fairly certain it won't reduce the pass rate. We should run each impacted live test pipeline a few times (via /azp run comments), fix any new failures (in separate PRs), and keep iterating until the pass rate is the same as master. If some pipelines are ready before others, we can split this PR into one per pipeline.

[mikeharder]

/azp run js - storage-blob - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

/azp run js - storage-file-share - tests

[mikeharder]

/azp run js - storage-queue - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

@HarshaNalluru: Does storage-file-datalake have live tests? I don't see a pipeline with this name.

[HarshaNalluru]

but why are retries and timeout specified in both karma.conf.js and the mocha command-line? When is karma.conf.js used?

• Node tests rely on the integration-test:node command, which is where we set the mocha retries for the node tests.
• Browser tests rely on integration-test:browser command(karma runs the browser tests for us), which relies on karma.conf.js, which is where we set the retries for the browser tests.

This PR is a good start, but it should not be merged until we are fairly certain it won't reduce the pass rate.

Sounds good.

[HarshaNalluru]

Does storage-file-datalake have live tests? I don't see a pipeline with this name.

It is a recently added package, it doesn't have the live tests pipeline, I don't think we are tracking it with an issue. /cc - @jeremymeng

[jeremymeng]

It is a recently added package, it doesn't have the live tests pipeline

@XiaoningLiu has been working with EngSys team to set up the pipeline.

[mikeharder]

All pipelines passed on the first run. I am somewhat surprised the retries are no longer needed, but it seems to be the case. If they pass one more time this should be merged.

[mikeharder]

/azp run js - storage-blob - tests

[mikeharder]

/azp run js - storage-file-share - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

/azp run js - storage-queue - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

/azp run js - storage-queue - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

/azp run js - storage-blob - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

/azp run js - storage-queue - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

/azp run js - storage-file-share - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mikeharder]

Based on the test runs, this may introduce a few new intermittent failures, but this seems fine since we are actively investigating and fixing them. Ready to merge.