Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names in cosmos for consistency #6110

Merged
merged 12 commits into from
Nov 18, 2019
Merged

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Nov 8, 2019

Fixes #5263 by updating names to align better with other packages. To avoid any breaking changes and needing a major version bump, we kept around old names and aliased them to the new ones.

Fixes Azure#5263 by updating names to align better with other packages.
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Cosmos labels Nov 8, 2019
@xirzec xirzec self-assigned this Nov 8, 2019
@xirzec
Copy link
Member Author

xirzec commented Nov 12, 2019

@southpolesteve @bterlson - this new version has the aliasing in place and I believe encompasses everything we chatted about.

@@ -168,6 +168,7 @@ export const Constants: {
CollectionPartitionInfo: string;
CollectionServiceInfo: string;
RetryAfterInMilliseconds: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is havingRetryAfterInMilliseconds and RetryAfterInMs intended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, is it that we want to keep it but mark it as deprecated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concern was if I removed the old one, we'd have a breaking change on our hands.

@xirzec
Copy link
Member Author

xirzec commented Nov 14, 2019

@southpolesteve any thoughts? All gates are green now

@southpolesteve
Copy link
Contributor

@xirzec Looks good to me. Thanks!

@xirzec xirzec merged commit b645f47 into Azure:master Nov 18, 2019
@xirzec xirzec deleted the renameCosmos branch November 18, 2019 22:09
xirzec added a commit to xirzec/azure-sdk-for-js that referenced this pull request Nov 19, 2019
xirzec added a commit that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cosmos] Naming Consistency
3 participants