-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update names in cosmos for consistency #6110
Conversation
Fixes Azure#5263 by updating names to align better with other packages.
@southpolesteve @bterlson - this new version has the aliasing in place and I believe encompasses everything we chatted about. |
@@ -168,6 +168,7 @@ export const Constants: { | |||
CollectionPartitionInfo: string; | |||
CollectionServiceInfo: string; | |||
RetryAfterInMilliseconds: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is havingRetryAfterInMilliseconds
and RetryAfterInMs
intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, is it that we want to keep it but mark it as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concern was if I removed the old one, we'd have a breaking change on our hands.
@southpolesteve any thoughts? All gates are green now |
@xirzec Looks good to me. Thanks! |
Fixes #5263 by updating names to align better with other packages. To avoid any breaking changes and needing a major version bump, we kept around old names and aliased them to the new ones.