[core-http] Fix broken browser bundle due to Rollup config #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
approved these changes
Oct 3, 2019
mikeharder
approved these changes
Oct 3, 2019
|
core-http browser tests appear to be passing now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes
core-http's browser bundle which started picking up Node-specific code after PR #5207. The issue was actually caused by a combination ofcore-tracing'sbrowserconfiguration andcore-http's RollupnodeResolveconfiguration, meaning that the wrong file was being pulled fromcore-tracingwhencore-http's browser bundle was created.The fix is to correct the
browserpath mapping forcore-tracingand remove themainentrypoint fromcore-http'snodeResolveconfiguration.