[Storage][File] Add async iterator for listing handles in DirectoryClient #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
commented
Sep 13, 2019
| options: DirectoryListHandlesSegmentOptions = {} | ||
| ): AsyncIterableIterator<Models.DirectoryListHandlesResponse> { | ||
| let listHandlesResponse; | ||
| if (!!marker || marker === undefined) { |
There was a problem hiding this comment.
@bterlson As you suggested this seems working to solve the continuation token issue.
There was a problem hiding this comment.
This should be done for the other listing methods as well, right? Separate PR?
There was a problem hiding this comment.
Yup all the paged async iterators. If this is good. Fix for othesrs could be in a seperate PR for storage, and another one for master branch.
jeremymeng
commented
Sep 13, 2019
| @@ -556,7 +581,7 @@ export class DirectoryClient extends StorageClient { | |||
| * @returns {AsyncIterableIterator<Models.DirectoryListFilesAndDirectoriesSegmentResponse>} | |||
| * @memberof DirectoryClient | |||
| */ | |||
| private async *listSegments( | |||
| private async *iterateFilesAndDirectoriesSegments( | |||
There was a problem hiding this comment.
Renaming them to avoid confusion between listSegments, listHandlesSegment, etc.
XiaoningLiu
approved these changes
Sep 16, 2019
jeremymeng
force-pushed
the
listhandles-async-iterator
branch
from
0d7b45f to
e8210a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5101