[Storage] Support SAS Connection String - storage-blob #4632
Conversation
HarshaNalluru
added
Client
| @@ -155,7 +155,8 @@ const skip = [ | |||
| // Size (263MB), Tempfile | |||
| "node/highlevel/recording_downloadtofile_should_success.js", | |||
| // Skipping for now, further investigation needed on the errors in playback | |||
| "browsers/blobclient/recording_startcopyfromclient.json" | |||
| "browsers/blobclient/recording_startcopyfromclient.json", | |||
| "node/blockblobclient/recording_can_be_created_with_a_sas_connection_string.js" | |||
There was a problem hiding this comment.
In blockblobclient, this specific test can_be_created_with_a_sas_connection_string failed during playback in NodeJS runtime, works fine in the browser.
[ live test succeeds for both node and browser ]
Tried fixing it, but couldn't. More investigation is required - #4633.
Skipping the test for now.
|
Is there any example on how to use this? |
I've added this comment to your issue #4923, @sarink. The storage-blob version 10 API that you've been using doesn't provide the support for passing the connection string directly. The new support for the SAS connection string has been added in the version 12.0.0-preview.2 - Link. npm link for 12.0.0-preview.2 version - https://www.npmjs.com/package/@azure/storage-blob/v/12.0.0-preview.2 Here's the sample that shows the usage - withConnString.ts |
Storage service provides two types of connection strings, one with the accountname and key and the other one SAS conn. string with SAS string and endpoints.
This PR adds the SAS connection string support to the existing connection string static methods and constructors.
Handled SAS connection string in the recorder and added tests and recordings accordingly.
Changes in this PR
https://github.com/Azure/azure-sdk-for-js/pull/4632/files?file-filters%5B%5D=.env&file-filters%5B%5D=.ts
https://github.com/Azure/azure-sdk-for-js/pull/4632/files?file-filters%5B%5D=.js&file-filters%5B%5D=.json