-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate signalr mgmt plane package #4606
Conversation
michaeljqzq
commented
Aug 1, 2019
- generated as per the latest version of open api specs
* @readonly | ||
* @enum {string} | ||
*/ | ||
export type ApiVersion7 = '2018-03-01-preview' | '2018-10-01'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amarzavery This are intended changes, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for Amar to confirm
@Zhiqing you should have used 4.2.0 version of the TS generator. Please regenerate again. Please provide the gulp codegen command and its output that was specified to generate this sdk. |
"@azure/ms-rest-azure-js": "^1.1.0", | ||
"@azure/ms-rest-js": "^1.1.0", | ||
"@azure/ms-rest-azure-js": "^1.3.2", | ||
"@azure/ms-rest-js": "^1.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using version 2 of ms-rest-js and ms-rest-azure-js libraries.
If we re-generate the code using the right version of the generator like @amarzavery said, the above should get fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autorest --reset
autorest --latest --typescript
autorest --info
AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Showing All Installed Extensions
Type Extension Name Version Location
core @microsoft.azure/autorest-core 2.0.4390 /Users/amarz/.autorest/@[email protected]
extension @microsoft.azure/autorest.modeler 2.3.51 /Users/amarz/.autorest/@[email protected]
extension @microsoft.azure/autorest.typescript 4.2.1 /Users/amarz/.autorest/@[email protected]
amarz-MBP:sdk amarz$
As you can see it installs 4.2.1 version of TS generator. After doing that, if you do NOT specify the --use="@microsoft.azure/[email protected]
switch then it is fine. Since autorest will automatically use the currently installed version of the TS generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeljqzq - An update, please use 4.2.2 version of @microsoft.azure/autorest.typescript
to generate the sdk.