-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPH] implement CheckpointManager methods #4583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We need a test for the in memory checkpointing feature
- create a in memory partition manager
- create an event processor and do checkpointing, stop after some time
- create another event processor with same partition manager. It should start processing from the checkpoint.
You can do this in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise looks good. I'm fine with the test being in a separate PR if need be.
The CheckpointManager is used by a PartitionProcessor to allow customers to create a persistent checkpoint based on their EventData or sequence/offset combo.
This PR is responsible for updating
updateCheckpoint
methods ofCheckpointManager