Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-auth] Bump @azure/core-auth version and sort dependencies #4564

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Jul 31, 2019

This change updates @azure/core-auth to 1.0.0-preview.3 following the release of 1.0.0-preview.2 and also sorts the dependencies list to be alphabetical.

@daviwil daviwil requested a review from mikeharder July 31, 2019 18:50
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should run rush update or rush update --full, since I believe package version bumps should also update pnpm-lock.json.

@daviwil
Copy link
Contributor Author

daviwil commented Jul 31, 2019

I just ran rush update and pnpm-lock.yaml wasn't changed. Running rush update --full caused it to be updated with a bunch of dependency version changes that I also saw in another PR of yours but nothing related to core-auth itself. Perhaps it's because all of our packages that depend on core-auth are now pinned to the publicly-released version and not the one that's in the repo?

@mikeharder
Copy link
Member

@daviwil: I think you are correct, pnpm-lock.yaml doesn't contain the versions of our own packages, only dependency versions. So no update is needed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants