-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record and playback - POC for skip functionality in common recorder #4336
Record and playback - POC for skip functionality in common recorder #4336
Conversation
Update Guildelines accordingly. |
public skip(): boolean { | ||
return skip.includes(this.filepath); | ||
} | ||
// public skip(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need commentted code here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this will be deleted.
This current PR is just to show how the skip list can be avoided and hear some feedback for it.
Instead of doing the updates in recorder.ts files, I'm planning to update the new common recorder #4281.
|
Thanks, @XiaoningLiu, I like the |
#4898 is merged, Closing this! |
Managing the list of test names would mean that we should frequently update them whenever a test name changes or a new test is added.
The plan is to avoid the skip list becoming stale in the following way.
Providing a .skip() method with the recorder so that it can be called from the
it
block to skip a test.Let us take a moment to understand what happens with this change.
recorder.skip("browser");
orrecorder.skip("node");
in theit
block based on the environment we want the test to be skippedit
block.[ A small tradeoff for getting rid of skip list and still add the convenience of invoking the recorder in beforeeach ]
[WIP] Will rebase and merge this in the common recorder module which is in PR - #4281
/cc - @ramya-rao-a @XiaoningLiu @kinelski @sadasant