Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests that handle browser websocket based errors #3930

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Disable tests that handle browser websocket based errors #3930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a618ff5
Disable tests that handle browser websocket based errors
ramya0820 Jun 18, 2019
1680e6e
Add comment
ramya0820 Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/servicebus/service-bus/test/serviceBusClient.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ describe("Create ServiceBusClient and Queue/Topic/Subscription Clients #RunInBro
});
});

describe("Errors with non existing Namespace #RunInBrowser", function(): void {
// Following tests have been disabled for browser for until Service Bus is updated to use core-amqp
// See https://github.com/Azure/azure-sdk-for-js/pull/3930
// Once resolved, the tests need to be enabled by adding #RuninBrowser to the describe message
describe("Errors with non existing Namespace", function(): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO comment above to enable this for browser once Service Bus starts using core-amqp and a link to the github issue

let sbClient: ServiceBusClient;
let errorWasThrown: boolean;
beforeEach(() => {
Expand Down