Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR hanaonazure/resource-manager] Microsoft.HanaOnAzure: Remove readOnly attribute from customer-provided properties in CreateHanaInstance #3637

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdk/hanaonazure/arm-hanaonazure/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,3 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
## Related projects

- [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)

![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/hanaonazure/arm-hanaonazure/README.png)
6 changes: 3 additions & 3 deletions sdk/hanaonazure/arm-hanaonazure/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"uglify-js": "^3.4.9"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/hanaonazure/arm-hanaonazure",
"homepage": "https://github.com/azure/azure-sdk-for-js",
"repository": {
"type": "git",
"url": "https://github.com/Azure/azure-sdk-for-js.git"
"url": "https://github.com/azure/azure-sdk-for-js.git"
},
"bugs": {
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
"url": "https://github.com/azure/azure-sdk-for-js/issues"
},
"files": [
"dist/**/*.js",
Expand Down
15 changes: 5 additions & 10 deletions sdk/hanaonazure/arm-hanaonazure/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ export interface Resource extends BaseResource {
readonly type?: string;
/**
* Resource location
* **NOTE: This property will not be serialized. It can only be populated by the server.**
*/
readonly location?: string;
location?: string;
/**
* Resource tags
* **NOTE: This property will not be serialized. It can only be populated by the server.**
Expand Down Expand Up @@ -102,9 +101,8 @@ export interface StorageProfile {
export interface OSProfile {
/**
* Specifies the host OS name of the HANA instance.
* **NOTE: This property will not be serialized. It can only be populated by the server.**
*/
readonly computerName?: string;
computerName?: string;
/**
* This property allows you to specify the type of the OS.
* **NOTE: This property will not be serialized. It can only be populated by the server.**
Expand All @@ -117,9 +115,8 @@ export interface OSProfile {
readonly version?: string;
/**
* Specifies the SSH public key used to access the operating system.
* **NOTE: This property will not be serialized. It can only be populated by the server.**
*/
readonly sshPublicKey?: string;
sshPublicKey?: string;
}

/**
Expand All @@ -128,9 +125,8 @@ export interface OSProfile {
export interface IpAddress {
/**
* Specifies the IP address of the network interface.
* **NOTE: This property will not be serialized. It can only be populated by the server.**
*/
readonly ipAddress?: string;
ipAddress?: string;
}

/**
Expand Down Expand Up @@ -191,9 +187,8 @@ export interface HanaInstance extends Resource {
readonly hwRevision?: string;
/**
* ARM ID of another HanaInstance that will share a network with this HanaInstance
* **NOTE: This property will not be serialized. It can only be populated by the server.**
*/
readonly partnerNodeId?: string;
partnerNodeId?: string;
/**
* State of provisioning of the HanaInstance. Possible values include: 'Accepted', 'Creating',
* 'Updating', 'Failed', 'Succeeded', 'Deleting', 'Migrating'
Expand Down
5 changes: 0 additions & 5 deletions sdk/hanaonazure/arm-hanaonazure/src/models/mappers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export const Resource: msRest.CompositeMapper = {
}
},
location: {
readOnly: true,
serializedName: "location",
type: {
name: "String"
Expand Down Expand Up @@ -151,7 +150,6 @@ export const OSProfile: msRest.CompositeMapper = {
className: "OSProfile",
modelProperties: {
computerName: {
readOnly: true,
serializedName: "computerName",
type: {
name: "String"
Expand All @@ -172,7 +170,6 @@ export const OSProfile: msRest.CompositeMapper = {
}
},
sshPublicKey: {
readOnly: true,
serializedName: "sshPublicKey",
type: {
name: "String"
Expand All @@ -189,7 +186,6 @@ export const IpAddress: msRest.CompositeMapper = {
className: "IpAddress",
modelProperties: {
ipAddress: {
readOnly: true,
serializedName: "ipAddress",
type: {
name: "String"
Expand Down Expand Up @@ -292,7 +288,6 @@ export const HanaInstance: msRest.CompositeMapper = {
}
},
partnerNodeId: {
readOnly: true,
serializedName: "properties.partnerNodeId",
type: {
name: "String"
Expand Down