Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid date in template changelog #32439

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix invalid date in template changelog #32439

merged 1 commit into from
Jan 6, 2025

Conversation

weshaggard
Copy link
Member

I think #31849 introduced this invalid date which has thrown off the changelog parser.

@weshaggard weshaggard requested a review from jeremymeng January 6, 2025 18:34
@github-actions github-actions bot added the EngSys This issue is impacting the engineering system. label Jan 6, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jeremymeng
jeremymeng approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's why! I had thought that might have had something to do with how we change the package versions in pipelines. Thanks for fixing it!

@jeremymeng jeremymeng merged commit caa0036 into main Jan 6, 2025
22 checks passed
@jeremymeng jeremymeng deleted the weshaggard-patch-1 branch January 6, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weshaggard @azure-sdk @jeremymeng