-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] update fix multiple accounts logic in IBC #32134
base: main
Are you sure you want to change the base?
[Identity] update fix multiple accounts logic in IBC #32134
Conversation
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- sdk/identity/identity/samples/v4/javascript/package.json: Language not supported
@@ -465,6 +446,7 @@ To work with multiple accounts for the same Client ID and Tenant ID, please prov | |||
silentRequest.resourceRequestMethod = options.proofOfPossessionOptions.resourceRequestMethod; | |||
silentRequest.resourceRequestUri = options.proofOfPossessionOptions.resourceRequestUrl; | |||
} | |||
await app.getTokenCache().getAllAccounts(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I need to add this because of a bug in msal, until that's fixed -AzureAD/microsoft-authentication-library-for-js#7303 (comment)
@xirzec
Packages impacted by this PR
@azure/identity
Issues associated with this PR
Fixes #28896
Describe the problem that is addressed by this PR
This PR attempts to solve two problems:
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Checklists