[communication] Move @azure/communication-call-automation to ESM/vitest #31680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
a team,
ckairen,
jeremymeng and
akania
as code owners
|
API change check API changes are not detected in this pull request. |
xirzec
reviewed
Nov 8, 2024
sdk/communication/communication-call-automation/test/utils/recordedClient.ts
Show resolved
Hide resolved
… feat/call-automation-esm
jeremymeng
approved these changes
Nov 18, 2024
sdk/communication/communication-call-automation/test/node/callMediaClient.spec.ts
Outdated
Show resolved
Hide resolved
… feat/call-automation-esm
mpodwysocki
requested review from
gfeitosa-msft,
phermanov-msft and
ilyapaliakou-msft
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Migrates package to ESM/vitest. Note that ServiceBus has issues with Browser loads that we can fix in a later revision as Buffer is not defined when you try to import any files. But then including Buffer then also causes issues with the unit tests.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists