Get real-time notification configuration from Chat Gateway #31472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angellan-msft
requested review from
ckairen,
jeremymeng,
a team,
LuChen-Microsoft and
xirzec
as code owners
|
API change check API changes are not detected in this pull request. |
jeremymeng
approved these changes
Oct 21, 2024
| resourceEndpoint: options?.resourceEndpoint ?? undefined, | ||
| gatewayApiVersion: options?.gatewayApiVersion ?? undefined, | ||
| additionalPolicies: options?.additionalPolicies ?? undefined, |
There was a problem hiding this comment.
It's following existing code, but I don't think you need to ?? with undefined
Suggested change
| additionalPolicies: options?.additionalPolicies ?? undefined, | |
| additionalPolicies: options?.additionalPolicies, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/communication-signaling
Describe the problem that is addressed by this PR
This PR is used for retrieving Trouter Config from Chat GW rather than hardcode it in signaling client.
There are 2 main changes.
1.Remove the "environment" from SignalingClientOptions as it should be retrieved from Chat GW;
2.Declare a TrouterConfigClientOptions and pass it to Signaling Client constructor since this is needed for signaling client to make http call to Chat Gateway.
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists