[core-client-rest] Fix serialization of non-string path parameters #31352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jeremymeng
approved these changes
Oct 9, 2024
MaryGao
approved these changes
Oct 10, 2024
MaryGao
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure-rest/core-clientIssues associated with this PR
numbertype for path parameter correctly #31349Describe the problem that is addressed by this PR
We generate RLCs that allow for path parameters to be
number. The change forallowReservedassumed that path parameters could only bestring, causing number parameters to not be serialized properly. This PR fixes that assumption.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Added a test to check for a number path parameter
Provide a list of related PRs (if any)
allowReservedandexplode#31058