[core-util] Create isNodeLike and isNodeRuntime #29086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
bterlson,
xirzec,
jeremymeng,
deyaaeldeen and
timovv
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
deyaaeldeen
reviewed
Mar 27, 2024
sdk/core/core-util/test/public/browser/checkEnvironment.spec.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
approved these changes
Mar 27, 2024
timovv
approved these changes
Mar 27, 2024
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
@timovv done |
| it("should return true", async function () { | ||
| assert.isFalse(isNode); | ||
| }); | ||
| }); | ||
|
|
||
| describe("isNodeRuntime (browser)", function () { | ||
| it("should return true", async function () { |
Merged
timovv
added a commit
that referenced
this pull request
Apr 16, 2024
### Packages impacted by this PR - `@azure/core-rest-pipeline` - `@typespec/ts-http-runtime` ### Describe the problem that is addressed by this PR Use `isNodeLike` in favor of the deprecated `isNode` in Core packages that depend on `core-util`. ### Provide a list of related PRs _(if any)_ - #29086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Reverts the behavior of
isNodechecks to ensure that it can still return true for Bun and Deno. IntroducingisNodeLiketo also have the same behavior asisNodeso we can deprecate the former function. We have also addedisNodeRuntimewhich then checks for an explicit Node.js runtime.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The previous attempt was to create a
isNodeLikeand be opt-in, versus this PR which gives the old behavior and new opt-in for strict Node runtimes.Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists