Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Add deleteMessages #28893

Closed
wants to merge 15 commits into from
Closed

[Service Bus] Add deleteMessages #28893

wants to merge 15 commits into from

Conversation

deyaaeldeen
Copy link
Member

Packages impacted by this PR

@azure/service-bus

Issues associated with this PR

N/A

Describe the problem that is addressed by this PR

Builds on @jeremymeng's work in #28627 to add an operation to delete messages.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

There is a question about what should be the default behavior in case of options absence. Currently, if the customer doesn't set the a message count nor a date, all messages will be deleted.

Are there test cases added in this PR? (If not, why?)

Yes.

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@deyaaeldeen deyaaeldeen changed the title Sb/delete messages [Service Bus] Add deleteMessages Mar 12, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 12, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/service-bus
@azure/core-amqp

@deyaaeldeen
Copy link
Member Author

Closing in favor of the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants