[Azure Monitor OpenTelemetry] Use dev-tool to run tests #28805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
requested review from
ckairen,
deyaaeldeen,
jeremymeng and
JacksonWeber
as code owners
hectorhdzg
changed the title
|
API change check API changes are not detected in this pull request. |
| "test:browser": "npm run unit-test:browser", | ||
| "unit-test:browser": "echo skipped", | ||
| "unit-test:node": "mocha -r ../../../common/tools/esm-workaround.js -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --reporter-option output=test-results.xml --timeout 1200000 --full-trace \"dist-esm/test/internal/**/*.test.js\"", | ||
| "unit-test:node:debug": "mocha --inspect-brk -r ../../../common/tools/esm-workaround.js -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --reporter-option output=test-results.xml --timeout 1200000 --full-trace \"dist-esm/test/internal/**/*.test.js\"", | ||
| "unit-test:node": "dev-tool run test:node-ts-input --no-test-proxy=true -- --timeout 1200000 \"test/internal/**/*.test.ts\"", |
There was a problem hiding this comment.
This is good, but just a little heads up..
we'll be moving to vitest soon for all the packages instead of mocha.
And while the tests are not migrated to vitest yet, we'll have to follow this #28801 in order to consume the core that is upgraded to esm, that would also fix the failures you observed.
PS: I don't have any concern on which commands we use in the short-term as long as the pipelines are green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry
@azure/monitor-opentelemetry-exporter